From 9b5257c9c99c4cb541d8e8e78fb04f008b1a9091 Mon Sep 17 00:00:00 2001 From: Jean-Michel Trivi Date: Thu, 18 Dec 2014 15:04:25 -0800 Subject: [PATCH] MediaSessionLegacyHelper uses global Application context MediaSessionLegacyHelper used a Context passed by an application which can cause a leak of Activity instances. Use the global Application context instead. Also prevent crash if a null Context is supplied (method not documented as requesting a non-null Context). Bug 18767503 Change-Id: I8281047d0af233a323f3fc11ababedff848829ec --- .../java/android/media/session/MediaSessionLegacyHelper.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/media/java/android/media/session/MediaSessionLegacyHelper.java b/media/java/android/media/session/MediaSessionLegacyHelper.java index 4b9a929dd0d4a..7ea269b1e5a54 100644 --- a/media/java/android/media/session/MediaSessionLegacyHelper.java +++ b/media/java/android/media/session/MediaSessionLegacyHelper.java @@ -69,12 +69,9 @@ public class MediaSessionLegacyHelper { } public static MediaSessionLegacyHelper getHelper(Context context) { - if (DEBUG) { - Log.d(TAG, "Attempting to get helper with context " + context); - } synchronized (sLock) { if (sInstance == null) { - sInstance = new MediaSessionLegacyHelper(context); + sInstance = new MediaSessionLegacyHelper(context.getApplicationContext()); } } return sInstance;