From c468d85edb7efa387ed0a12d2f812d2df0a8994d Mon Sep 17 00:00:00 2001 From: Beverly Date: Thu, 17 Feb 2022 16:47:25 +0000 Subject: [PATCH] Don't update persistent msgs when dozing Else, we'll keep unnecessarily waking up the device. Test: atest SystemUITests Fixes: 218445866 Change-Id: I28d8358b7bab8dce64755f5aa2e8175e3e103121 --- .../systemui/statusbar/KeyguardIndicationController.java | 6 ++++-- .../statusbar/KeyguardIndicationControllerTest.java | 5 ++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/KeyguardIndicationController.java b/packages/SystemUI/src/com/android/systemui/statusbar/KeyguardIndicationController.java index 0509a7caa719e..7f43f9f3d2158 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/KeyguardIndicationController.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/KeyguardIndicationController.java @@ -327,7 +327,9 @@ public class KeyguardIndicationController { private void updateOrganizedOwnedDevice() { // avoid calling this method since it has an IPC mOrganizationOwnedDevice = whitelistIpcs(this::isOrganizationOwnedDevice); - updatePersistentIndications(false, KeyguardUpdateMonitor.getCurrentUser()); + if (!mDozing) { + updateDisclosure(); + } } private void updateDisclosure() { @@ -1185,7 +1187,7 @@ public class KeyguardIndicationController { mTopIndicationView.clearMessages(); mRotateTextViewController.clearMessages(); } else { - updatePersistentIndications(false, KeyguardUpdateMonitor.getCurrentUser()); + updateIndication(false); } } }; diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/KeyguardIndicationControllerTest.java b/packages/SystemUI/tests/src/com/android/systemui/statusbar/KeyguardIndicationControllerTest.java index 466d954e7be07..65271bc456b43 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/KeyguardIndicationControllerTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/KeyguardIndicationControllerTest.java @@ -779,8 +779,11 @@ public class KeyguardIndicationControllerTest extends SysuiTestCase { public void testOnKeyguardShowingChanged_showing_updatesPersistentMessages() { createController(); - // GIVEN keyguard is showing + // GIVEN keyguard is showing and not dozing when(mKeyguardStateController.isShowing()).thenReturn(true); + mController.setVisible(true); + mExecutor.runAllReady(); + reset(mRotateTextViewController); // WHEN keyguard showing changed called mKeyguardStateControllerCallback.onKeyguardShowingChanged();