Merge "Fix/suppress statsd google-explicit-constructor warnings"

cmds/statsd/src/anomaly/AlarmMonitor.h

@@ -42,7 +42,7 @@ namespace statsd {
  * Timestamps are in seconds since epoch in a uint32, so will fail in year 2106.
  */
 struct InternalAlarm : public RefBase {
-    InternalAlarm(uint32_t timestampSec) : timestampSec(timestampSec) {
+    explicit InternalAlarm(uint32_t timestampSec) : timestampSec(timestampSec) {
     }
 
     const uint32_t timestampSec;

cmds/statsd/src/condition/ConditionWizard.h

@@ -29,7 +29,7 @@ namespace statsd {
 class ConditionWizard : public virtual android::RefBase {
 public:
     ConditionWizard(){};  // for testing
-    ConditionWizard(std::vector<sp<ConditionTracker>>& conditionTrackers)
+    explicit ConditionWizard(std::vector<sp<ConditionTracker>>& conditionTrackers)
         : mAllConditions(conditionTrackers){};
 
     virtual ~ConditionWizard(){};

cmds/statsd/src/config/ConfigKey.h

@@ -33,7 +33,7 @@ using std::string;
 class ConfigKey {
 public:
     ConfigKey();
-    explicit ConfigKey(const ConfigKey& that);
+    ConfigKey(const ConfigKey& that);
     ConfigKey(int uid, const int64_t& id);
     ~ConfigKey();
 

cmds/statsd/src/external/ResourceHealthManagerPuller.h

@@ -28,7 +28,7 @@ namespace statsd {
  */
 class ResourceHealthManagerPuller : public StatsPuller {
 public:
-    ResourceHealthManagerPuller(int tagId);
+    explicit ResourceHealthManagerPuller(int tagId);
     bool PullInternal(vector<std::shared_ptr<LogEvent>>* data) override;
 };
 

cmds/statsd/src/external/StatsCompanionServicePuller.h

@@ -25,7 +25,7 @@ namespace statsd {
 
 class StatsCompanionServicePuller : public StatsPuller {
 public:
-    StatsCompanionServicePuller(int tagId);
+    explicit StatsCompanionServicePuller(int tagId);
     bool PullInternal(vector<std::shared_ptr<LogEvent> >* data) override;
 
     void SetStatsCompanionService(sp<IStatsCompanionService> statsCompanionService) override;

cmds/statsd/src/external/StatsPuller.h

@@ -33,7 +33,7 @@ namespace statsd {
 
 class StatsPuller : public virtual RefBase {
 public:
-    StatsPuller(const int tagId);
+    explicit StatsPuller(const int tagId);
 
     virtual ~StatsPuller() {}
 

cmds/statsd/src/logd/LogEvent.h

@@ -158,7 +158,7 @@ private:
      * Don't copy, it's slower. If we really need this we can add it but let's try to
      * avoid it.
      */
-    explicit LogEvent(const LogEvent&);
+    LogEvent(const LogEvent&);
 
     /**
      * Parses a log_msg into a LogEvent object.

cmds/statsd/src/socket/StatsSocketListener.h

@@ -35,7 +35,7 @@ namespace statsd {
 
 class StatsSocketListener : public SocketListener, public virtual android::RefBase {
 public:
-    StatsSocketListener(const sp<LogListener>& listener);
+    explicit StatsSocketListener(const sp<LogListener>& listener);
 
     virtual ~StatsSocketListener();
 
@@ -51,4 +51,4 @@ private:
 };
 }  // namespace statsd
 }  // namespace os
-}  // namespace android
+}  // namespace android