From 697b7b033ea15c13a054d7f9ed2544520ea361b4 Mon Sep 17 00:00:00 2001 From: Caitlin Cassidy Date: Wed, 27 Apr 2022 18:32:49 +0000 Subject: [PATCH] [Media Recs] Remove smartspace cardinality method now that we only show 3 albums at most. Bug: 223603970 Test: MediaControlPanelTest Change-Id: I4f49bb9653e333d84b2caf8319eefff2387dc1c1 --- .../android/systemui/media/MediaControlPanel.java | 13 ++----------- .../android/systemui/media/MediaControlPanelTest.kt | 4 ---- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/media/MediaControlPanel.java b/packages/SystemUI/src/com/android/systemui/media/MediaControlPanel.java index 21cab57507c68..5a32e91b1d188 100644 --- a/packages/SystemUI/src/com/android/systemui/media/MediaControlPanel.java +++ b/packages/SystemUI/src/com/android/systemui/media/MediaControlPanel.java @@ -1288,7 +1288,7 @@ public class MediaControlPanel { } logSmartspaceCardReported(SMARTSPACE_CARD_CLICK_EVENT, interactedSubcardRank, - getSmartspaceSubCardCardinality()); + mSmartspaceMediaItemsCount); if (shouldSmartspaceRecItemOpenInForeground(action)) { // Request to unlock the device if the activity needs to be opened in foreground. @@ -1373,13 +1373,4 @@ public class MediaControlPanel { interactedSubcardRank, interactedSubcardCardinality); } - - private int getSmartspaceSubCardCardinality() { - if (!mMediaCarouselController.getMediaCarouselScrollHandler().getQsExpanded() - && mSmartspaceMediaItemsCount > 3) { - return 3; - } - - return mSmartspaceMediaItemsCount; - } -} \ No newline at end of file +} diff --git a/packages/SystemUI/tests/src/com/android/systemui/media/MediaControlPanelTest.kt b/packages/SystemUI/tests/src/com/android/systemui/media/MediaControlPanelTest.kt index 2bf96a0a40039..76171b2c4054b 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/media/MediaControlPanelTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/media/MediaControlPanelTest.kt @@ -124,7 +124,6 @@ public class MediaControlPanelTest : SysuiTestCase() { @Mock private lateinit var collapsedSet: ConstraintSet @Mock private lateinit var mediaOutputDialogFactory: MediaOutputDialogFactory @Mock private lateinit var mediaCarouselController: MediaCarouselController - @Mock private lateinit var mediaCarouselScrollHandler: MediaCarouselScrollHandler @Mock private lateinit var falsingManager: FalsingManager @Mock private lateinit var transitionParent: ViewGroup private lateinit var appIcon: ImageView @@ -294,9 +293,6 @@ public class MediaControlPanelTest : SysuiTestCase() { */ private fun initMediaViewHolderMocks() { whenever(seekBarViewModel.progress).thenReturn(seekBarData) - whenever(mediaCarouselController.mediaCarouselScrollHandler) - .thenReturn(mediaCarouselScrollHandler) - whenever(mediaCarouselScrollHandler.qsExpanded).thenReturn(false) // Set up mock views for the players appIcon = ImageView(context)