From 6977f723b7e54f2caf64d40516d92247b68519fa Mon Sep 17 00:00:00 2001 From: Lucas Dupin Date: Wed, 16 Feb 2022 10:42:50 -0800 Subject: [PATCH] Safeguard against threading issues on dependency Test: make Change-Id: I92650a97051b286a19258cbee8a3761cf6ecc783 --- .../systemui/statusbar/connectivity/WifiSignalController.java | 2 ++ .../statusbar/connectivity/NetworkControllerWifiTest.java | 1 + 2 files changed, 3 insertions(+) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/connectivity/WifiSignalController.java b/packages/SystemUI/src/com/android/systemui/statusbar/connectivity/WifiSignalController.java index 5361a67160448..2b924a420306e 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/connectivity/WifiSignalController.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/connectivity/WifiSignalController.java @@ -34,6 +34,7 @@ import com.android.settingslib.graph.SignalDrawable; import com.android.settingslib.mobile.TelephonyIcons; import com.android.settingslib.wifi.WifiStatusTracker; import com.android.systemui.R; +import com.android.systemui.util.Assert; import java.io.PrintWriter; @@ -190,6 +191,7 @@ public class WifiSignalController extends SignalController } private void handleStatusUpdated() { + Assert.isMainThread(); copyWifiStates(); notifyListenersIfNecessary(); } diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/connectivity/NetworkControllerWifiTest.java b/packages/SystemUI/tests/src/com/android/systemui/statusbar/connectivity/NetworkControllerWifiTest.java index 9f152e1e2fe5f..b7b3088a9e268 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/connectivity/NetworkControllerWifiTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/connectivity/NetworkControllerWifiTest.java @@ -56,6 +56,7 @@ public class NetworkControllerWifiTest extends NetworkControllerBaseTest { @Before public void setUp() throws Exception { super.setUp(); + allowTestableLooperAsMainThread(); when(mWifiInfo.makeCopy(anyLong())).thenReturn(mWifiInfo); when(mWifiInfo.isPrimary()).thenReturn(true); }