Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix discovered logging issues for Autofill." into udc-dev

Browse Source
This commit is contained in:
Jiewen Lei
2023-05-12 20:56:07 +00:00
committed by Android (Google) Code Review
parent db1b28df98 6bbeb251b2
commit 691b6c2963
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
services/autofill/java/com/android/server/autofill/FillRequestEventLogger.java
View File

@@ -74,9 +74,6 @@ public final class FillRequestEventLogger {
public static final int TRIGGER_REASON_SERVED_FROM_CACHED_RESPONSE = public static final int TRIGGER_REASON_SERVED_FROM_CACHED_RESPONSE =
AUTOFILL_FILL_REQUEST_REPORTED__REQUEST_TRIGGER_REASON__TRIGGER_REASON_SERVED_FROM_CACHED_RESPONSE; AUTOFILL_FILL_REQUEST_REPORTED__REQUEST_TRIGGER_REASON__TRIGGER_REASON_SERVED_FROM_CACHED_RESPONSE;
// Augmented autofill currently doesn't have an assigned request_id, use -2 as the magic number.
public static final int AUGMENTED_AUTOFILL_REQUEST_ID = -2;
private final int mSessionId; private final int mSessionId;
private Optional<FillRequestEventInternal> mEventInternal; private Optional<FillRequestEventInternal> mEventInternal;

3
services/autofill/java/com/android/server/autofill/Session.java
View File

@@ -1158,7 +1158,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState
} }
mSessionFlags.mAugmentedAutofillOnly = true; mSessionFlags.mAugmentedAutofillOnly = true;
mFillRequestEventLogger.maybeSetRequestId(AUGMENTED_AUTOFILL_REQUEST_ID); mFillRequestEventLogger.maybeSetRequestId(AUGMENTED_AUTOFILL_REQUEST_ID);
mFillRequestEventLogger.maybeSetIsAugmented(mSessionFlags.mAugmentedAutofillOnly); mFillRequestEventLogger.maybeSetIsAugmented(true);
mFillRequestEventLogger.logAndEndEvent(); mFillRequestEventLogger.logAndEndEvent();
triggerAugmentedAutofillLocked(flags); triggerAugmentedAutofillLocked(flags);
return; return;
@@ -4818,6 +4818,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState
mFillRequestEventLogger.maybeSetAppPackageUid(uid); mFillRequestEventLogger.maybeSetAppPackageUid(uid);
mFillRequestEventLogger.maybeSetFlags(mFlags); mFillRequestEventLogger.maybeSetFlags(mFlags);
mFillRequestEventLogger.maybeSetRequestId(AUGMENTED_AUTOFILL_REQUEST_ID); mFillRequestEventLogger.maybeSetRequestId(AUGMENTED_AUTOFILL_REQUEST_ID);
mFillRequestEventLogger.maybeSetIsAugmented(true);
mFillRequestEventLogger.logAndEndEvent(); mFillRequestEventLogger.logAndEndEvent();
final ViewState viewState = mViewStates.get(mCurrentViewId); final ViewState viewState = mViewStates.get(mCurrentViewId);