From 23699315c2bee0de84142a6aadd22acdfc406ba9 Mon Sep 17 00:00:00 2001 From: Songchun Fan Date: Tue, 30 Nov 2021 17:18:58 -0800 Subject: [PATCH] [SettingsLib] fix test after IPackageManager flag change ag/16288469 changed some of IPackageManager methods to use long flags instead of int flags. That CL didn't include a fix for Settings Lib tests. This CL fixes that. BUG: 208469125 Test: atest com.android.settingslib.users.AppRestrictionsHelperTest Change-Id: I0c2a7db2844baf84d382fdbdc5ce88ffe360a173 --- .../com/android/settingslib/users/AppCopyingHelperTest.java | 5 +++-- .../android/settingslib/users/AppRestrictionsHelperTest.java | 5 +++-- .../settingslib/applications/ApplicationsStateRoboTest.java | 3 ++- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/SettingsLib/tests/integ/src/com/android/settingslib/users/AppCopyingHelperTest.java b/packages/SettingsLib/tests/integ/src/com/android/settingslib/users/AppCopyingHelperTest.java index 111bcc46907ee..2a5c43cae2899 100644 --- a/packages/SettingsLib/tests/integ/src/com/android/settingslib/users/AppCopyingHelperTest.java +++ b/packages/SettingsLib/tests/integ/src/com/android/settingslib/users/AppCopyingHelperTest.java @@ -19,6 +19,7 @@ package com.android.settingslib.users; import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.anyBoolean; import static org.mockito.Matchers.anyInt; +import static org.mockito.Matchers.anyLong; import static org.mockito.Matchers.argThat; import static org.mockito.Matchers.eq; import static org.mockito.Mockito.times; @@ -135,11 +136,11 @@ public class AppCopyingHelperTest extends BaseTest { ApplicationInfo info = new ApplicationInfo(); info.privateFlags |= ApplicationInfo.PRIVATE_FLAG_HIDDEN; info.flags |= ApplicationInfo.FLAG_INSTALLED; - when(mIpm.getApplicationInfo(eq("app3"), anyInt(), eq(testUserId))) + when(mIpm.getApplicationInfo(eq("app3"), anyLong(), eq(testUserId))) .thenReturn(info); info = new ApplicationInfo(); - when(mIpm.getApplicationInfo(eq("app4"), anyInt(), eq(testUserId))) + when(mIpm.getApplicationInfo(eq("app4"), anyLong(), eq(testUserId))) .thenReturn(info); mHelper.installSelectedApps(); diff --git a/packages/SettingsLib/tests/integ/src/com/android/settingslib/users/AppRestrictionsHelperTest.java b/packages/SettingsLib/tests/integ/src/com/android/settingslib/users/AppRestrictionsHelperTest.java index b216a2a3fb78d..2522e956a25ea 100644 --- a/packages/SettingsLib/tests/integ/src/com/android/settingslib/users/AppRestrictionsHelperTest.java +++ b/packages/SettingsLib/tests/integ/src/com/android/settingslib/users/AppRestrictionsHelperTest.java @@ -17,6 +17,7 @@ package com.android.settingslib.users; import static org.mockito.Matchers.anyInt; +import static org.mockito.Matchers.anyLong; import static org.mockito.Matchers.argThat; import static org.mockito.Matchers.eq; import static org.mockito.Matchers.nullable; @@ -133,12 +134,12 @@ public class AppRestrictionsHelperTest extends BaseTest { ApplicationInfo info = new ApplicationInfo(); info.privateFlags |= ApplicationInfo.PRIVATE_FLAG_HIDDEN; info.flags |= ApplicationInfo.FLAG_INSTALLED; - when(mIpm.getApplicationInfo(eq("app2"), anyInt(), eq(testUserId))) + when(mIpm.getApplicationInfo(eq("app2"), anyLong(), eq(testUserId))) .thenReturn(info); mHelper.setPackageSelected("app3", false); info = new ApplicationInfo(); - when(mIpm.getApplicationInfo(eq("app3"), anyInt(), eq(testUserId))) + when(mIpm.getApplicationInfo(eq("app3"), anyLong(), eq(testUserId))) .thenReturn(info); AppRestrictionsHelper.OnDisableUiForPackageListener mockListener = diff --git a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/applications/ApplicationsStateRoboTest.java b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/applications/ApplicationsStateRoboTest.java index 5efce4da970fc..6d576a10eea2a 100644 --- a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/applications/ApplicationsStateRoboTest.java +++ b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/applications/ApplicationsStateRoboTest.java @@ -23,6 +23,7 @@ import static com.google.common.truth.Truth.assertThat; import static org.mockito.ArgumentMatchers.eq; import static org.mockito.Matchers.any; import static org.mockito.Matchers.anyInt; +import static org.mockito.Matchers.anyLong; import static org.mockito.Matchers.anyString; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.never; @@ -203,7 +204,7 @@ public class ApplicationsStateRoboTest { infos.add(createApplicationInfo("test.hidden.module.2")); infos.add(createApplicationInfo("test.package.3")); when(mPackageManagerService.getInstalledApplications( - anyInt() /* flags */, anyInt() /* userId */)).thenReturn(new ParceledListSlice(infos)); + anyLong() /* flags */, anyInt() /* userId */)).thenReturn(new ParceledListSlice(infos)); ApplicationsState.sInstance = null; mApplicationsState =