Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fail WorkSourceTest if reading from parcel failed" into udc-dev

Browse Source
This commit is contained in:
Treehugger Robot
2023-05-02 14:57:20 +00:00
committed by Android (Google) Code Review
parent dc80918e17 28954cc7d9
commit 688353955d
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
core/tests/coretests/jni/NativeWorkSourceParcelTest.cpp
View File

@@ -77,15 +77,18 @@ static void nativeUnparcelAndVerifyWorkSource(JNIEnv* env, jobject /* obj */, jo
Parcel* parcel = nativeGetParcelData(env, wsParcel); Parcel* parcel = nativeGetParcelData(env, wsParcel);
int32_t endMarker; int32_t endMarker;
// read WorkSource and if no error read end marker status_t err = ws.readFromParcel(parcel);
status_t err = ws.readFromParcel(parcel) ?: parcel->readInt32(&endMarker);
int32_t dataAvailable = parcel->dataAvail();
if (err != OK) { if (err != OK) {
ALOGE("WorkSource readFromParcel failed %d", err); jniThrowException(env, "java/lang/IllegalArgumentException",
StringPrintf("WorkSource readFromParcel failed: %d", err).c_str());
}
err = parcel->readInt32(&endMarker);
if (err != OK) {
jniThrowException(env, "java/lang/IllegalArgumentException",
StringPrintf("Failed to read endMarker: %d", err).c_str());
} }
// Now we have a native WorkSource object, verify it. // Now we have a native WorkSource object, verify it.
int32_t dataAvailable = parcel->dataAvail();
if (dataAvailable > 0) { // not all data read from the parcel if (dataAvailable > 0) { // not all data read from the parcel
jniThrowException(env, "java/lang/IllegalArgumentException", jniThrowException(env, "java/lang/IllegalArgumentException",
StringPrintf("WorkSource contains more data than native read (%d)", StringPrintf("WorkSource contains more data than native read (%d)",