From 4c3b7e9a6269379b0a7632ac6c801ee96f0343f5 Mon Sep 17 00:00:00 2001 From: Joanne Chung Date: Wed, 19 May 2021 11:40:04 +0800 Subject: [PATCH] Fix ServicePermissionsTest#testDumpProtected The translation system service should verify the caller holds Permission#DUMP before dumpping the log. Bug: 186756551 Test: atest ServicePermissionsTest#testDumpProtected Test: atest CtsTranslationTestCases Test: manual dumpsys translation Change-Id: Ic1ea90d9467d5ac25353f08374ce157c60976b8e --- .../android/server/translation/TranslationManagerService.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/services/translation/java/com/android/server/translation/TranslationManagerService.java b/services/translation/java/com/android/server/translation/TranslationManagerService.java index 628f8cdc8f0c2..415f055829601 100644 --- a/services/translation/java/com/android/server/translation/TranslationManagerService.java +++ b/services/translation/java/com/android/server/translation/TranslationManagerService.java @@ -48,6 +48,7 @@ import android.view.translation.UiTranslationSpec; import com.android.internal.annotations.GuardedBy; import com.android.internal.os.IResultReceiver; +import com.android.internal.util.DumpUtils; import com.android.server.infra.AbstractMasterSystemService; import com.android.server.infra.FrameworkResourcesServiceNameResolver; @@ -289,6 +290,8 @@ public final class TranslationManagerService */ @Override public void dump(FileDescriptor fd, PrintWriter pw, String[] args) { + if (!DumpUtils.checkDumpPermission(getContext(), TAG, pw)) return; + synchronized (mLock) { dumpLocked("", pw); }