From a3d3414c537d7c6eaa5c034999f98ad9e09e20b1 Mon Sep 17 00:00:00 2001 From: Qinmei Du Date: Thu, 1 Dec 2022 01:39:41 +0000 Subject: [PATCH] Make disabledProviderList nullable Test: deployed locally Bug: 253157211 Change-Id: I30099403143436f11cd8947eb43c7e250ef92ba7 --- .../com/android/credentialmanager/CredentialManagerRepo.kt | 6 +++--- .../src/com/android/credentialmanager/DataConverter.kt | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/CredentialManager/src/com/android/credentialmanager/CredentialManagerRepo.kt b/packages/CredentialManager/src/com/android/credentialmanager/CredentialManagerRepo.kt index 0cc11946ca85b..1ce1bc304bf9a 100644 --- a/packages/CredentialManager/src/com/android/credentialmanager/CredentialManagerRepo.kt +++ b/packages/CredentialManager/src/com/android/credentialmanager/CredentialManagerRepo.kt @@ -59,7 +59,7 @@ class CredentialManagerRepo( ) { val requestInfo: RequestInfo private val providerEnabledList: List - private val providerDisabledList: List + private val providerDisabledList: List? // TODO: require non-null. val resultReceiver: ResultReceiver? @@ -143,7 +143,7 @@ class CredentialManagerRepo( providerEnabledList as List, requestDisplayInfo, context) val providerDisabledList = CreateFlowUtils.toDisabledProviderList( // Handle runtime cast error - providerDisabledList as List, context) + providerDisabledList, context) var defaultProvider: EnabledProviderInfo? = null var remoteEntry: RemoteInfo? = null providerEnabledList.forEach{providerInfo -> providerInfo.createOptions = @@ -209,7 +209,7 @@ class CredentialManagerRepo( ) } - private fun testDisabledProviderList(): List { + private fun testDisabledProviderList(): List? { return listOf( DisabledProviderData("com.lastpass.lpandroid"), DisabledProviderData("com.google.android.youtube") diff --git a/packages/CredentialManager/src/com/android/credentialmanager/DataConverter.kt b/packages/CredentialManager/src/com/android/credentialmanager/DataConverter.kt index b96f686c02fb9..357c55dc27701 100644 --- a/packages/CredentialManager/src/com/android/credentialmanager/DataConverter.kt +++ b/packages/CredentialManager/src/com/android/credentialmanager/DataConverter.kt @@ -209,12 +209,12 @@ class CreateFlowUtils { } fun toDisabledProviderList( - providerDataList: List, + providerDataList: List?, context: Context, - ): List { + ): List? { // TODO: get from the actual service info val packageManager = context.packageManager - return providerDataList.map { + return providerDataList?.map { val pkgInfo = packageManager .getPackageInfo(it.providerFlattenedComponentName, PackageManager.PackageInfoFlags.of(0))