From 682ad7ab5514cf01d584f04e9ad4f3a40b13078c Mon Sep 17 00:00:00 2001 From: Matthew Ng Date: Tue, 9 Apr 2019 15:48:01 -0700 Subject: [PATCH] Use nav frame height to differentiate quick switch vs edge gesture Originally used shorter nav height in gestural mode. Fix by using the frame height to make back execute at a higher position compared to quick switch. Fixes: 130185782 Bug: 112934365 Test: manual and in landscape Change-Id: I1befdd4bd35a251926a7d361b4e1cb131e03ded3 --- packages/SystemUI/res/values/internal.xml | 1 + .../systemui/statusbar/phone/EdgeBackGestureHandler.java | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/SystemUI/res/values/internal.xml b/packages/SystemUI/res/values/internal.xml index 930cfce65b619..c29a51f6178ea 100644 --- a/packages/SystemUI/res/values/internal.xml +++ b/packages/SystemUI/res/values/internal.xml @@ -17,6 +17,7 @@ @*android:dimen/status_bar_height @*android:dimen/navigation_bar_height + @*android:dimen/navigation_bar_frame_height @*android:dimen/navigation_bar_height_car_mode diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/EdgeBackGestureHandler.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/EdgeBackGestureHandler.java index 212666f24b36c..09ce95fe07643 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/EdgeBackGestureHandler.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/EdgeBackGestureHandler.java @@ -17,6 +17,7 @@ package com.android.systemui.statusbar.phone; import android.content.Context; import android.content.pm.ParceledListSlice; +import android.content.res.Resources; import android.graphics.PixelFormat; import android.graphics.Point; import android.graphics.PointF; @@ -140,6 +141,7 @@ public class EdgeBackGestureHandler implements DisplayListener { private WindowManager.LayoutParams mEdgePanelLp; public EdgeBackGestureHandler(Context context, OverviewProxyService overviewProxyService) { + final Resources res = context.getResources(); mContext = context; mDisplayId = context.getDisplayId(); mMainExecutor = context.getMainExecutor(); @@ -148,10 +150,9 @@ public class EdgeBackGestureHandler implements DisplayListener { mEdgeWidth = QuickStepContract.getEdgeSensitivityWidth(context); mTouchSlop = ViewConfiguration.get(context).getScaledTouchSlop(); - mSwipeThreshold = context.getResources() - .getDimension(R.dimen.navigation_edge_action_drag_threshold); + mSwipeThreshold = res.getDimension(R.dimen.navigation_edge_action_drag_threshold); - mNavBarHeight = context.getResources().getDimensionPixelSize(R.dimen.navigation_bar_height); + mNavBarHeight = res.getDimensionPixelSize(R.dimen.navigation_bar_frame_height); } /**