From 6811a9976be9d899abb90bfe439f62f7e0bd0d54 Mon Sep 17 00:00:00 2001
From: Santiago Seifert <aquilescanta@google.com>
Date: Tue, 21 Sep 2021 11:07:40 +0100
Subject: [PATCH] Release acquired MediaMetadataRetriever

Bug: 200173116
Test: atest MediaPlayerApiTest
Change-Id: Ieafb4ebab025bc4af571ec2f48cc087136bddab8
---
 .../functional/CodecTest.java                 | 33 ++++++++-----------
 1 file changed, 13 insertions(+), 20 deletions(-)

diff --git a/media/tests/MediaFrameworkTest/src/com/android/mediaframeworktest/functional/CodecTest.java b/media/tests/MediaFrameworkTest/src/com/android/mediaframeworktest/functional/CodecTest.java
index 4361b96166e3b..5510e735beb35 100644
--- a/media/tests/MediaFrameworkTest/src/com/android/mediaframeworktest/functional/CodecTest.java
+++ b/media/tests/MediaFrameworkTest/src/com/android/mediaframeworktest/functional/CodecTest.java
@@ -16,12 +16,6 @@
 
 package com.android.mediaframeworktest.functional;
 
-
-
-//import android.content.Resources;
-import com.android.mediaframeworktest.MediaFrameworkTest;
-import com.android.mediaframeworktest.MediaNames;
-
 import android.content.res.AssetFileDescriptor;
 import android.graphics.Bitmap;
 import android.graphics.BitmapFactory;
@@ -36,15 +30,12 @@ import android.os.Looper;
 import android.os.SystemClock;
 import android.util.Log;
 
-import java.io.File;
-import java.io.FileWriter;
+import com.android.mediaframeworktest.MediaFrameworkTest;
+import com.android.mediaframeworktest.MediaNames;
+
 import java.io.IOException;
 import java.io.InputStream;
-import java.io.OutputStream;
-import java.io.Writer;
-import java.io.FileOutputStream;
 import java.util.HashSet;
-import java.util.Random;
 import java.util.Set;
 /**
  * Junit / Instrumentation test case for the media player api
@@ -539,14 +530,16 @@ public class CodecTest {
         try{
             BitmapFactory mBitmapFactory = new BitmapFactory();
 
-            MediaMetadataRetriever mMediaMetadataRetriever = new MediaMetadataRetriever();
-            try {
-                mMediaMetadataRetriever.setDataSource(filePath);
-            } catch(Exception e) {
-                e.printStackTrace();
-                return false;
+            Bitmap outThumbnail;
+            try (MediaMetadataRetriever mediaMetadataRetriever = new MediaMetadataRetriever()) {
+                try {
+                    mediaMetadataRetriever.setDataSource(filePath);
+                } catch (Exception e) {
+                    e.printStackTrace();
+                    return false;
+                }
+                outThumbnail = mediaMetadataRetriever.getFrameAtTime(-1);
             }
-            Bitmap outThumbnail = mMediaMetadataRetriever.getFrameAtTime(-1);
 
             //Verify the thumbnail
             Bitmap goldenBitmap = mBitmapFactory.decodeFile(goldenPath);
@@ -567,7 +560,7 @@ public class CodecTest {
                     return false;
                 }
            }
-        }catch (Exception e){
+        } catch (Exception e) {
             Log.v(TAG, e.toString());
             return false;
         }