From 680e357976565d8fb08af11e137e253c70b97c58 Mon Sep 17 00:00:00 2001 From: Ivan Podogov Date: Thu, 20 Jun 2019 12:49:18 +0100 Subject: [PATCH] Don't dismiss keyguard when enabling it Introduced in ag/2664156, dismissing a keyguard when it's being disabled has also caused it to be shown whenever it's being enabled (or re-enabled, or calling DPM.setKeyguardDisabled when keyguard is enabled). This change should stop keyguard randomly popping up. Bug: 133730775 Test: manual Change-Id: I49f28714b2d149f13168e7564947aaf09c593117 --- .../server/devicepolicy/DevicePolicyManagerService.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java b/services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java index 8b61208c0b66d..e5518d05e9c5a 100644 --- a/services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java +++ b/services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java @@ -11018,7 +11018,11 @@ public class DevicePolicyManagerService extends BaseIDevicePolicyManager { return false; } mLockPatternUtils.setLockScreenDisabled(disabled, userId); - mInjector.getIWindowManager().dismissKeyguard(null /* callback */, null /* message */); + if (disabled) { + mInjector + .getIWindowManager() + .dismissKeyguard(null /* callback */, null /* message */); + } DevicePolicyEventLogger .createEvent(DevicePolicyEnums.SET_KEYGUARD_DISABLED) .setAdmin(who)