From afd43e48c69ccd0b27049939c8c53ecdcbc7f5af Mon Sep 17 00:00:00 2001 From: Chiachang Wang Date: Tue, 10 Dec 2019 10:07:12 +0800 Subject: [PATCH] Add TetherConfigParcel to improve startTetheringWithConfiguration In order to support extensibility, update the interface between netd to take a configuration parcel, instead of fixed parameters. Bug: 145777247 Test: atest FrameworksNetTests Test: build, flash, on/off tethering Change-Id: I3dbccc46ce4ddccfb6d518de240e4604b7f95eed --- .../java/com/android/server/NetworkManagementService.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/NetworkManagementService.java b/services/core/java/com/android/server/NetworkManagementService.java index 9efaad848ccc1..8fa0d7e942225 100644 --- a/services/core/java/com/android/server/NetworkManagementService.java +++ b/services/core/java/com/android/server/NetworkManagementService.java @@ -57,6 +57,7 @@ import android.net.NetworkPolicyManager; import android.net.NetworkStats; import android.net.NetworkUtils; import android.net.RouteInfo; +import android.net.TetherConfigParcel; import android.net.TetherStatsParcel; import android.net.UidRange; import android.net.UidRangeParcel; @@ -1016,7 +1017,10 @@ public class NetworkManagementService extends INetworkManagementService.Stub { mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG); // an odd number of addrs will fail try { - mNetdService.tetherStartWithConfiguration(usingLegacyDnsProxy, dhcpRange); + final TetherConfigParcel config = new TetherConfigParcel(); + config.usingLegacyDnsProxy = usingLegacyDnsProxy; + config.dhcpRanges = dhcpRange; + mNetdService.tetherStartWithConfiguration(config); } catch (RemoteException | ServiceSpecificException e) { throw new IllegalStateException(e); }