From ad3dea12eec02584a8126979c9b965c8a86d7ff3 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Mon, 15 Aug 2016 14:51:48 -0700 Subject: [PATCH] Fix google-explicit-constructor warnings in common_time. * Add explicit keyword to conversion constructors. Bug: 28341362 Test: build with WITH_TIDY=1 Change-Id: Ieab4756042e77cfadda35e34f78f515058ae0bb3 --- libs/common_time/common_clock_service.h | 2 +- libs/common_time/common_time_config_service.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/common_time/common_clock_service.h b/libs/common_time/common_clock_service.h index bd663f06d43a2..aea507ec0f304 100644 --- a/libs/common_time/common_clock_service.h +++ b/libs/common_time/common_clock_service.h @@ -53,7 +53,7 @@ class CommonClockService : public BnCommonClock, void notifyOnTimelineChanged(uint64_t timelineID); private: - CommonClockService(CommonTimeServer& timeServer) + explicit CommonClockService(CommonTimeServer& timeServer) : mTimeServer(timeServer) { }; virtual void binderDied(const wp& who); diff --git a/libs/common_time/common_time_config_service.h b/libs/common_time/common_time_config_service.h index 89806dd87e297..23abb1a9e47e8 100644 --- a/libs/common_time/common_time_config_service.h +++ b/libs/common_time/common_time_config_service.h @@ -49,7 +49,7 @@ class CommonTimeConfigService : public BnCommonTimeConfig { virtual status_t forceNetworklessMasterMode(); private: - CommonTimeConfigService(CommonTimeServer& timeServer) + explicit CommonTimeConfigService(CommonTimeServer& timeServer) : mTimeServer(timeServer) { } CommonTimeServer& mTimeServer;