From f04cce25d1b2b938042933f93295430b3da3a0aa Mon Sep 17 00:00:00 2001 From: Andrei Stingaceanu Date: Thu, 14 Apr 2016 13:19:44 +0100 Subject: [PATCH] Keyboard shortcuts: UI polish 2 1. Changed list title from body1 (14sp, regular) to body2 (14sp, bold). 2. Reduced spacing between list title and first list item by 3dp 3. Reduced height from divider line to list by 20dp (I had this in redlines as 20dp, but I think that added an additional 20dp to the component so it ended up being 40dp in implementation) 4. Reduced padding between app icon and app name from 32dp to 24dp (this is a change from original redlines so that the text aligns 72dp from the edge of the dialog which is a standard Material keyline) Bug: 28169928 Change-Id: I01b92486353fa990158819a2d18b16cd910d7ded --- packages/SystemUI/res/layout/keyboard_shortcut_app_item.xml | 2 +- .../res/layout/keyboard_shortcuts_category_separator.xml | 2 +- .../SystemUI/res/layout/keyboard_shortcuts_category_title.xml | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/SystemUI/res/layout/keyboard_shortcut_app_item.xml b/packages/SystemUI/res/layout/keyboard_shortcut_app_item.xml index 63b759b7b2764..52cab72df1203 100644 --- a/packages/SystemUI/res/layout/keyboard_shortcut_app_item.xml +++ b/packages/SystemUI/res/layout/keyboard_shortcut_app_item.xml @@ -26,7 +26,7 @@ android:id="@+id/keyboard_shortcuts_icon" android:layout_width="24dp" android:layout_height="24dp" - android:layout_marginEnd="32dp" + android:layout_marginEnd="24dp" android:layout_gravity="center_vertical" android:visibility="gone" android:layout_alignParentStart="true" diff --git a/packages/SystemUI/res/layout/keyboard_shortcuts_category_separator.xml b/packages/SystemUI/res/layout/keyboard_shortcuts_category_separator.xml index 778ef8ffd3dd6..879505e87606c 100644 --- a/packages/SystemUI/res/layout/keyboard_shortcuts_category_separator.xml +++ b/packages/SystemUI/res/layout/keyboard_shortcuts_category_separator.xml @@ -21,5 +21,5 @@ android:layout_marginStart="24dp" android:layout_marginTop="8dp" android:layout_marginEnd="0dp" - android:layout_marginBottom="20dp" + android:layout_marginBottom="0dp" android:background="?android:attr/dividerHorizontal" /> diff --git a/packages/SystemUI/res/layout/keyboard_shortcuts_category_title.xml b/packages/SystemUI/res/layout/keyboard_shortcuts_category_title.xml index 381fb165df10d..8414223b76547 100644 --- a/packages/SystemUI/res/layout/keyboard_shortcuts_category_title.xml +++ b/packages/SystemUI/res/layout/keyboard_shortcuts_category_title.xml @@ -19,7 +19,8 @@ android:layout_width="wrap_content" android:layout_height="match_parent" android:textSize="14sp" + android:fontFamily="sans-serif-medium" android:paddingStart="24dp" android:paddingTop="20dp" android:paddingEnd="24dp" - android:paddingBottom="13dp"/> + android:paddingBottom="10dp"/>