From ba35aa1ebfe946318a1f7e69cc29d98e715d10ed Mon Sep 17 00:00:00 2001 From: Lais Andrade Date: Fri, 14 Oct 2022 14:30:43 +0000 Subject: [PATCH] Update Vibrator documentation for support check methods. Update documentation for methods areAllEffectsSupported and areAllPrimitivesSupported to explain the default behavior for empty queries. The behavior remains unchanged. Change-Id: I23dd792af7e3ee2c70fec136fb7db4965a7195be Fix: 237509304 Test: N/A --- core/java/android/os/Vibrator.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/core/java/android/os/Vibrator.java b/core/java/android/os/Vibrator.java index 465d90d366984..4137ca18b068d 100644 --- a/core/java/android/os/Vibrator.java +++ b/core/java/android/os/Vibrator.java @@ -527,7 +527,8 @@ public abstract class Vibrator { } /** - * Query whether the vibrator supports all the given effects. + * Query whether the vibrator supports all the given effects. If no argument is provided this + * method will always return {@link #VIBRATION_EFFECT_SUPPORT_YES}. * *

If an effect is not supported, the system may still automatically fall back to a simpler * vibration instead, which is not optimised for the specific device, however vibration isn't @@ -549,7 +550,8 @@ public abstract class Vibrator { *

Use {@link #areEffectsSupported(int...)} to get individual results for each effect. * * @param effectIds Which effects to query for. - * @return Whether all the effects are natively supported by the device. + * @return Whether all specified effects are natively supported by the device. Empty query + * defaults to {@link #VIBRATION_EFFECT_SUPPORT_YES}. */ @VibrationEffectSupport public final int areAllEffectsSupported( @@ -598,7 +600,8 @@ public abstract class Vibrator { } /** - * Query whether the vibrator supports all of the given primitives. + * Query whether the vibrator supports all of the given primitives. If no argument is provided + * this method will always return {@code true}. * *

If a primitive is not supported by the device, then no vibration will occur if * it is played. @@ -606,7 +609,7 @@ public abstract class Vibrator { *

Use {@link #arePrimitivesSupported(int...)} to get individual results for each primitive. * * @param primitiveIds Which primitives to query for. - * @return Whether all specified primitives are supported. + * @return Whether all specified primitives are supported. Empty query defaults to {@code true}. */ public final boolean areAllPrimitivesSupported( @NonNull @VibrationEffect.Composition.PrimitiveType int... primitiveIds) {