Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Minor Autofill javadoc fixes." into oc-dev am: 560221752e

Browse Source 
am: 948e9ff4d3

Change-Id: I90a42739dfa01c49fdbf799c49e3d569abcedf11
This commit is contained in:
Felipe Leme
2017-08-25 19:47:23 +00:00
committed by android-build-merger
parent 6fab5790bf 948e9ff4d3
commit 6660644576
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/java/android/service/autofill/AutofillService.java
View File

@@ -306,7 +306,7 @@ import com.android.internal.os.SomeArgs;
* <pre class="prettyprint"> * <pre class="prettyprint">
* private static String getCanonicalDomain(String domain) { * private static String getCanonicalDomain(String domain) {
* InternetDomainName idn = InternetDomainName.from(domain); * InternetDomainName idn = InternetDomainName.from(domain);
* while (!idn.isTopPrivateDomain() && idn != null) { * while (idn != null && !idn.isTopPrivateDomain()) {
* idn = idn.parent(); * idn = idn.parent();
* } * }
* return idn == null ? null : idn.toString(); * return idn == null ? null : idn.toString();
@@ -314,8 +314,9 @@ import com.android.internal.os.SomeArgs;
* </pre> * </pre>
* *
* <p>If the association between the web domain and app package cannot be verified through the steps * <p>If the association between the web domain and app package cannot be verified through the steps
* above, the service can still autofill the app, but it should warn the user about the potential * above, but the service thinks that it is appropriate to fill persisted credentials that are
* data leakage first, and askfor the user to confirm. For example, the service could: * stored for the web domain, the service should warn the user about the potential data
* leakage first, and ask for the user to confirm. For example, the service could:
* *
* <ol> * <ol>
* <li>Create a dataset that requires * <li>Create a dataset that requires
@@ -324,7 +325,7 @@ import com.android.internal.os.SomeArgs;
* <li>Include the web domain in the custom presentation for the * <li>Include the web domain in the custom presentation for the
* {@link Dataset.Builder#setValue(AutofillId, AutofillValue, android.widget.RemoteViews) * {@link Dataset.Builder#setValue(AutofillId, AutofillValue, android.widget.RemoteViews)
* dataset value}. * dataset value}.
* <li>When the user select that dataset, show a disclaimer dialog explaining that the app is * <li>When the user selects that dataset, show a disclaimer dialog explaining that the app is
* requesting credentials for a web domain, but the service could not verify if the app owns * requesting credentials for a web domain, but the service could not verify if the app owns
* that domain. If the user agrees, then the service can unlock the dataset. * that domain. If the user agrees, then the service can unlock the dataset.
* <li>Similarly, when adding a {@link SaveInfo} object for the request, the service should * <li>Similarly, when adding a {@link SaveInfo} object for the request, the service should
@@ -333,7 +334,7 @@ import com.android.internal.os.SomeArgs;
* *
* <p>This same procedure could also be used when the autofillable data is contained inside an * <p>This same procedure could also be used when the autofillable data is contained inside an
* {@code IFRAME}, in which case the WebView generates a new autofill context when a node inside * {@code IFRAME}, in which case the WebView generates a new autofill context when a node inside
* the {@code IFRAME} is focused, which the root node containing the {@code IFRAME}'s {@code src} * the {@code IFRAME} is focused, with the root node containing the {@code IFRAME}'s {@code src}
* attribute on {@link android.app.assist.AssistStructure.ViewNode#getWebDomain()}. A typical and * attribute on {@link android.app.assist.AssistStructure.ViewNode#getWebDomain()}. A typical and
* legitimate use case for this scenario is a financial app that allows the user * legitimate use case for this scenario is a financial app that allows the user
* to login on different bank accounts. For example, a financial app {@code my_financial_app} could * to login on different bank accounts. For example, a financial app {@code my_financial_app} could