From 7f01ff915b58de55b6c57fee3389993b52f32c7f Mon Sep 17 00:00:00 2001 From: Bernardo Rufino Date: Wed, 5 Feb 2020 13:20:23 +0000 Subject: [PATCH] Return null for getWindowParams() on system-rendered toasts Bug: 144754526 Test: atest android.widget.cts29.ToastTest android.widget.cts.ToastTest Change-Id: I768424ab157d64cfc922cd307ffcc688a6ab6de3 --- core/java/android/widget/Toast.java | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/core/java/android/widget/Toast.java b/core/java/android/widget/Toast.java index a2c70b9afbeea..c942dd404b0ed 100644 --- a/core/java/android/widget/Toast.java +++ b/core/java/android/widget/Toast.java @@ -455,8 +455,19 @@ public class Toast { * @hide */ @UnsupportedAppUsage - public WindowManager.LayoutParams getWindowParams() { - return mTN.mParams; + @Nullable public WindowManager.LayoutParams getWindowParams() { + if (Compatibility.isChangeEnabled(CHANGE_TEXT_TOASTS_IN_THE_SYSTEM)) { + if (mNextView != null) { + // Custom toasts + return mTN.mParams; + } else { + // Text toasts + return null; + } + } else { + // Text and custom toasts are app-rendered + return mTN.mParams; + } } /**