From 6d09d547b06b86b337e8e16c2585b3882a5bb1dc Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Mon, 29 Aug 2016 14:51:31 -0700 Subject: [PATCH] Fix google-explicit-constructor warnings. * Add explicit keyword to conversion constructors. Bug: 28341362 Test: build with WITH_TIDY=1 Change-Id: Ic550902559b0800bdcfc0b1d301313a909434eed --- libs/input/SpriteController.h | 2 +- .../core/jni/com_android_server_input_InputApplicationHandle.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/input/SpriteController.h b/libs/input/SpriteController.h index 905833c7877d8..7fc8d6fd5197f 100644 --- a/libs/input/SpriteController.h +++ b/libs/input/SpriteController.h @@ -214,7 +214,7 @@ private: virtual ~SpriteImpl(); public: - SpriteImpl(const sp controller); + explicit SpriteImpl(const sp controller); virtual void setIcon(const SpriteIcon& icon); virtual void setVisible(bool visible); diff --git a/services/core/jni/com_android_server_input_InputApplicationHandle.h b/services/core/jni/com_android_server_input_InputApplicationHandle.h index 62c85704f61de..e6f25cce1f987 100644 --- a/services/core/jni/com_android_server_input_InputApplicationHandle.h +++ b/services/core/jni/com_android_server_input_InputApplicationHandle.h @@ -26,7 +26,7 @@ namespace android { class NativeInputApplicationHandle : public InputApplicationHandle { public: - NativeInputApplicationHandle(jweak objWeak); + explicit NativeInputApplicationHandle(jweak objWeak); virtual ~NativeInputApplicationHandle(); jobject getInputApplicationHandleObjLocalRef(JNIEnv* env);