From 643bc5ce5eb48d448b9d4bfd109b9222e19b8cf2 Mon Sep 17 00:00:00 2001 From: Evgenii Stepanov Date: Wed, 8 Dec 2021 16:40:32 -0800 Subject: [PATCH] Revert "Pass MTE RuntimeFlags to AppZygote." The change affects non-MTE devices, contrary to the claims in the description. This reverts commit 8895ef1256411a4eda96aa4aa6dd4c9147118737. Bug: 207557677 Test: CtsTaggingHostTestCases Change-Id: I033ee79ce05db87586358ba954ecfcaf8aaa6249 --- core/java/android/os/AppZygote.java | 8 ++------ services/core/java/com/android/server/am/ProcessList.java | 3 +-- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/core/java/android/os/AppZygote.java b/core/java/android/os/AppZygote.java index c8b4226ecae0f..74b814ea4159d 100644 --- a/core/java/android/os/AppZygote.java +++ b/core/java/android/os/AppZygote.java @@ -45,8 +45,6 @@ public class AppZygote { // Last UID/GID of the range the AppZygote can setuid()/setgid() to private final int mZygoteUidGidMax; - private final int mZygoteRuntimeFlags; - private final Object mLock = new Object(); /** @@ -58,13 +56,11 @@ public class AppZygote { private final ApplicationInfo mAppInfo; - public AppZygote(ApplicationInfo appInfo, int zygoteUid, int uidGidMin, int uidGidMax, - int runtimeFlags) { + public AppZygote(ApplicationInfo appInfo, int zygoteUid, int uidGidMin, int uidGidMax) { mAppInfo = appInfo; mZygoteUid = zygoteUid; mZygoteUidGidMin = uidGidMin; mZygoteUidGidMax = uidGidMax; - mZygoteRuntimeFlags = runtimeFlags; } /** @@ -114,7 +110,7 @@ public class AppZygote { mZygoteUid, mZygoteUid, null, // gids - mZygoteRuntimeFlags, // runtimeFlags + 0, // runtimeFlags "app_zygote", // seInfo abi, // abi abi, // acceptedAbiList diff --git a/services/core/java/com/android/server/am/ProcessList.java b/services/core/java/com/android/server/am/ProcessList.java index f35afa5b7ca0f..b77270f5963bb 100644 --- a/services/core/java/com/android/server/am/ProcessList.java +++ b/services/core/java/com/android/server/am/ProcessList.java @@ -2238,8 +2238,7 @@ public final class ProcessList { // not the calling one. appInfo.packageName = app.getHostingRecord().getDefiningPackageName(); appInfo.uid = uid; - int runtimeFlags = decideTaggingLevel(app); - appZygote = new AppZygote(appInfo, uid, firstUid, lastUid, runtimeFlags); + appZygote = new AppZygote(appInfo, uid, firstUid, lastUid); mAppZygotes.put(app.info.processName, uid, appZygote); zygoteProcessList = new ArrayList(); mAppZygoteProcesses.put(appZygote, zygoteProcessList);