diff --git a/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPointPreference.java b/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPointPreference.java index e5977f3130919..92995a8e850dc 100644 --- a/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPointPreference.java +++ b/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPointPreference.java @@ -70,6 +70,19 @@ public class AccessPointPreference extends Preference { R.string.accessibility_wifi_signal_full }; + public static String generatePreferenceKey(AccessPoint accessPoint) { + StringBuilder builder = new StringBuilder(); + + if (TextUtils.isEmpty(accessPoint.getBssid())) { + builder.append(accessPoint.getSsidStr()); + } else { + builder.append(accessPoint.getBssid()); + } + + builder.append(',').append(accessPoint.getSecurity()); + return builder.toString(); + } + // Used for dummy pref. public AccessPointPreference(Context context, AttributeSet attrs) { super(context, attrs); diff --git a/packages/SettingsLib/src/com/android/settingslib/wifi/TestAccessPointBuilder.java b/packages/SettingsLib/src/com/android/settingslib/wifi/TestAccessPointBuilder.java index 903421fc701bd..4307cb0f1b7bb 100644 --- a/packages/SettingsLib/src/com/android/settingslib/wifi/TestAccessPointBuilder.java +++ b/packages/SettingsLib/src/com/android/settingslib/wifi/TestAccessPointBuilder.java @@ -36,6 +36,7 @@ public class TestAccessPointBuilder { private static final int MAX_RSSI = -55; // set some sensible defaults + private String mBssid = null; private int mRssi = AccessPoint.UNREACHABLE_RSSI; private int mNetworkId = WifiConfiguration.INVALID_NETWORK_ID; private String ssid = "TestSsid"; @@ -57,6 +58,7 @@ public class TestAccessPointBuilder { WifiConfiguration wifiConfig = new WifiConfiguration(); wifiConfig.networkId = mNetworkId; + wifiConfig.BSSID = mBssid; bundle.putString(AccessPoint.KEY_SSID, ssid); bundle.putParcelable(AccessPoint.KEY_CONFIG, wifiConfig); @@ -179,4 +181,9 @@ public class TestAccessPointBuilder { mNetworkId = networkId; return this; } + + public TestAccessPointBuilder setBssid(String bssid) { + mBssid = bssid; + return this; + } } diff --git a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/wifi/AccessPointPreferenceTest.java b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/wifi/AccessPointPreferenceTest.java new file mode 100644 index 0000000000000..335653bc2f186 --- /dev/null +++ b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/wifi/AccessPointPreferenceTest.java @@ -0,0 +1,61 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.android.settingslib.wifi; + +import static com.google.common.truth.Truth.assertThat; + +import android.content.Context; + +import com.android.settingslib.SettingLibRobolectricTestRunner; +import com.android.settingslib.TestConfig; + +import org.junit.Test; +import org.junit.runner.RunWith; +import org.robolectric.RuntimeEnvironment; +import org.robolectric.annotation.Config; + +@RunWith(SettingLibRobolectricTestRunner.class) +@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION) +public class AccessPointPreferenceTest { + + private Context mContext = RuntimeEnvironment.application; + + @Test + public void generatePreferenceKey_shouldReturnSsidPlusSecurity() { + String ssid = "ssid"; + int security = AccessPoint.SECURITY_WEP; + String expectedKey = ssid + ',' + security; + + TestAccessPointBuilder builder = new TestAccessPointBuilder(mContext); + builder.setSsid(ssid).setSecurity(security); + + assertThat(AccessPointPreference.generatePreferenceKey(builder.build())) + .isEqualTo(expectedKey); + } + + @Test + public void generatePreferenceKey_shouldReturnBssidPlusSecurity() { + String bssid = "bssid"; + int security = AccessPoint.SECURITY_WEP; + String expectedKey = bssid + ',' + security; + + TestAccessPointBuilder builder = new TestAccessPointBuilder(mContext); + builder.setBssid(bssid).setSecurity(security); + + assertThat(AccessPointPreference.generatePreferenceKey(builder.build())) + .isEqualTo(expectedKey); + } +}