Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

audio: SpatializerHelper: fix exceptions when head tracking is not supported

Browse Source 
Do not call head tracking APIs on native spatializer when it does not
support head tracking.

Bug: 224623509
Test: manual enabling/disabling of spatial audio
Change-Id: I3be6b3f05c9542404379a07f4fc734e45a75152a
This commit is contained in:
Eric Laurent
2022-03-17 12:13:02 +01:00
parent 8e98ddc6b0
commit 63300ce049
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
services/core/java/com/android/server/audio/SpatializerHelper.java
View File

@@ -139,6 +139,7 @@ public class SpatializerHelper {
private @Nullable SpatializerCallback mSpatCallback; private @Nullable SpatializerCallback mSpatCallback;
private @Nullable SpatializerHeadTrackingCallback mSpatHeadTrackingCallback; private @Nullable SpatializerHeadTrackingCallback mSpatHeadTrackingCallback;
private @Nullable HelperDynamicSensorCallback mDynSensorCallback; private @Nullable HelperDynamicSensorCallback mDynSensorCallback;
private boolean mIsHeadTrackingSupported = false;
// default attributes and format that determine basic availability of spatialization // default attributes and format that determine basic availability of spatialization
private static final AudioAttributes DEFAULT_ATTRIBUTES = new AudioAttributes.Builder() private static final AudioAttributes DEFAULT_ATTRIBUTES = new AudioAttributes.Builder()
@@ -813,8 +814,9 @@ public class SpatializerHelper {
mSpat = AudioSystem.getSpatializer(mSpatCallback); mSpat = AudioSystem.getSpatializer(mSpatCallback);
try { try {
mSpat.setLevel((byte) Spatializer.SPATIALIZER_IMMERSIVE_LEVEL_MULTICHANNEL); mSpat.setLevel((byte) Spatializer.SPATIALIZER_IMMERSIVE_LEVEL_MULTICHANNEL);
mIsHeadTrackingSupported = mSpat.isHeadTrackingSupported();
//TODO: register heatracking callback only when sensors are registered //TODO: register heatracking callback only when sensors are registered
if (mSpat.isHeadTrackingSupported()) { if (mIsHeadTrackingSupported) {
mSpat.registerHeadTrackingCallback(mSpatHeadTrackingCallback); mSpat.registerHeadTrackingCallback(mSpatHeadTrackingCallback);
} }
} catch (RemoteException e) { } catch (RemoteException e) {
@@ -832,12 +834,15 @@ public class SpatializerHelper {
if (mSpat != null) { if (mSpat != null) {
mSpatCallback = null; mSpatCallback = null;
try { try {
mSpat.registerHeadTrackingCallback(null); if (mIsHeadTrackingSupported) {
mSpat.registerHeadTrackingCallback(null);
}
mHeadTrackerAvailable = false; mHeadTrackerAvailable = false;
mSpat.release(); mSpat.release();
} catch (RemoteException e) { } catch (RemoteException e) {
Log.e(TAG, "Can't set release spatializer cleanly", e); Log.e(TAG, "Can't set release spatializer cleanly", e);
} }
mIsHeadTrackingSupported = false;
mSpat = null; mSpat = null;
} }
} }
@@ -1124,7 +1129,7 @@ public class SpatializerHelper {
} }
break; break;
} }
return true; return mIsHeadTrackingSupported;
} }
private void dispatchActualHeadTrackingMode(int newMode) { private void dispatchActualHeadTrackingMode(int newMode) {
@@ -1314,13 +1319,8 @@ public class SpatializerHelper {
Log.e(TAG, "not " + action + " sensors, null spatializer"); Log.e(TAG, "not " + action + " sensors, null spatializer");
return; return;
} }
try { if (!mIsHeadTrackingSupported) {
if (!mSpat.isHeadTrackingSupported()) { Log.e(TAG, "not " + action + " sensors, spatializer doesn't support headtracking");
Log.e(TAG, "not " + action + " sensors, spatializer doesn't support headtracking");
return;
}
} catch (RemoteException e) {
Log.e(TAG, "not " + action + " sensors, error querying headtracking", e);
return; return;
} }
int headHandle = -1; int headHandle = -1;