Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "allow dumpstate to work for non-root users." into gingerbread

Browse Source
This commit is contained in:
Nick Kralevich
2010-10-21 11:35:49 -07:00
committed by Android (Google) Code Review
parent 7dc08fb070 77d87aa7ff
commit 62d0970c82
1 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
cmds/dumpstate/dumpstate.c
View File

@@ -216,19 +216,21 @@ int main(int argc, char *argv[]) {
fclose(cmdline); fclose(cmdline);
} }
/* switch to non-root user and group */ if (getuid() == 0) {
gid_t groups[] = { AID_LOG, AID_SDCARD_RW, AID_MOUNT }; /* switch to non-root user and group */
if (setgroups(sizeof(groups)/sizeof(groups[0]), groups) != 0) { gid_t groups[] = { AID_LOG, AID_SDCARD_RW, AID_MOUNT };
LOGE("Unable to setgroups, aborting: %s\n", strerror(errno)); if (setgroups(sizeof(groups)/sizeof(groups[0]), groups) != 0) {
return -1; LOGE("Unable to setgroups, aborting: %s\n", strerror(errno));
} return -1;
if (setgid(AID_SHELL) != 0) { }
LOGE("Unable to setgid, aborting: %s\n", strerror(errno)); if (setgid(AID_SHELL) != 0) {
return -1; LOGE("Unable to setgid, aborting: %s\n", strerror(errno));
} return -1;
if (setuid(AID_SHELL) != 0) { }
LOGE("Unable to setuid, aborting: %s\n", strerror(errno)); if (setuid(AID_SHELL) != 0) {
return -1; LOGE("Unable to setuid, aborting: %s\n", strerror(errno));
return -1;
}
} }
char path[PATH_MAX], tmp_path[PATH_MAX]; char path[PATH_MAX], tmp_path[PATH_MAX];