From b8da6cb5b2aa6d2f46c4c49e96fcbaa1a05f21e5 Mon Sep 17 00:00:00 2001 From: Eric Laurent Date: Thu, 7 Apr 2011 09:41:46 -0700 Subject: [PATCH] Do not disable effect in AudioEffect destructor. Current implementation of AudioEffect class destructor disables the effect before disconnecting from IAudioEffect interface. This is problematic when more than one client has a handle on the same effect engine as destroying one handle will disable the effect which is not the intended behavior. Change-Id: I10eacf981506469a7ef4eb9a1650813f0848de5d --- media/libmedia/AudioEffect.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/media/libmedia/AudioEffect.cpp b/media/libmedia/AudioEffect.cpp index aadeba54d7d6e..a043329fa3f08 100644 --- a/media/libmedia/AudioEffect.cpp +++ b/media/libmedia/AudioEffect.cpp @@ -170,7 +170,6 @@ AudioEffect::~AudioEffect() LOGV("Destructor %p", this); if (mStatus == NO_ERROR || mStatus == ALREADY_EXISTS) { - setEnabled(false); if (mIEffect != NULL) { mIEffect->disconnect(); mIEffect->asBinder()->unlinkToDeath(mIEffectClient);