Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Document that SystemProperties.set() can throw RuntimeException"

Browse Source
This commit is contained in:
Treehugger Robot
2019-09-20 05:53:03 +00:00
committed by Gerrit Code Review
parent 134fe7616b 39373b2e81
commit 6265eea819
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/java/android/os/SystemProperties.java
View File

@@ -184,6 +184,8 @@ public class SystemProperties {
* Set the value for the given {@code key} to {@code val}. * Set the value for the given {@code key} to {@code val}.
* *
* @throws IllegalArgumentException if the {@code val} exceeds 91 characters * @throws IllegalArgumentException if the {@code val} exceeds 91 characters
* @throws RuntimeException if the property cannot be set, for example, if it was blocked by
* SELinux. libc will log the underlying reason.
* @hide * @hide
*/ */
@UnsupportedAppUsage @UnsupportedAppUsage

2
core/jni/android_os_SystemProperties.cpp
View File

@@ -109,7 +109,7 @@ void SystemProperties_set(JNIEnv *env, jobject clazz, jstring keyJ,
if (!ConvertKeyAndForward(env, keyJ, true, handler)) { if (!ConvertKeyAndForward(env, keyJ, true, handler)) {
// Must have been a failure in SetProperty. // Must have been a failure in SetProperty.
jniThrowException(env, "java/lang/RuntimeException", jniThrowException(env, "java/lang/RuntimeException",
"failed to set system property"); "failed to set system property (check logcat for reason)");
} }
} }