From 618578e8cb9115eed6d96aec70c9dd355edde1e0 Mon Sep 17 00:00:00 2001 From: Nate Myren Date: Mon, 4 Apr 2022 16:24:49 -0700 Subject: [PATCH] Remove REVIEW_REQUIRED from droidfooder phones Pixels no longer have the REVIEW_REQUIRED flag set. Droidfooders need the flag removed from their devices. Bug: 227186603 Test: manual Change-Id: I024bb6ebac5dbc589a20b17117b891d2c7e0f1a7 --- .../server/pm/permission/PermissionManagerServiceImpl.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java b/services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java index c524fb7ae9e57..260b3b41b8e3e 100644 --- a/services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java +++ b/services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java @@ -2800,12 +2800,14 @@ public class PermissionManagerServiceImpl implements PermissionManagerServiceInt } // Remove review flag as it is not necessary anymore - if (!NOTIFICATION_PERMISSIONS.contains(perm)) { + // TODO(b/227186603) re-enable check for notification permission once + // droidfood state has been cleared + //if (!NOTIFICATION_PERMISSIONS.contains(perm)) { if ((flags & FLAG_PERMISSION_REVIEW_REQUIRED) != 0) { flags &= ~FLAG_PERMISSION_REVIEW_REQUIRED; wasChanged = true; } - } + //} if ((flags & FLAG_PERMISSION_REVOKED_COMPAT) != 0 && !isPermissionSplitFromNonRuntime(permName,