From ce8d9d1672e8321466aab745083233239422557d Mon Sep 17 00:00:00 2001 From: Guang Zhu Date: Tue, 15 Sep 2009 14:17:04 -0700 Subject: [PATCH] Add more error message if the script failed to pull result file from device. --- tests/DumpRenderTree/assets/run_page_cycler.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/DumpRenderTree/assets/run_page_cycler.py b/tests/DumpRenderTree/assets/run_page_cycler.py index 4a68d7216fb32..7dd4a882fd804 100755 --- a/tests/DumpRenderTree/assets/run_page_cycler.py +++ b/tests/DumpRenderTree/assets/run_page_cycler.py @@ -88,8 +88,15 @@ def main(options, args): result_file = "/sdcard/load_test_result.txt" shell_cmd_str = adb_cmd + " pull " + result_file + " " + results_dir - adb_output = subprocess.Popen(shell_cmd_str, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE).communicate()[0] - logging.info(adb_output) + (adb_output, err) = subprocess.Popen( + shell_cmd_str, shell=True, + stdout=subprocess.PIPE, stderr=subprocess.PIPE).communicate() + if not os.path.isfile(os.path.join(results_dir, "load_test_result.txt")): + logging.error("Failed to pull result file.") + logging.error("adb stdout:") + logging.error(adb_output) + logging.error("adb stderr:") + logging.error(err) logging.info("Results are stored under: " + results_dir + "/load_test_result.txt\n") if '__main__' == __name__: