From 11ee5468763b1c57103390d046581c4358380716 Mon Sep 17 00:00:00 2001
From: Victor Hsieh <victorhsieh@google.com>
Date: Fri, 27 Apr 2018 15:04:34 -0700
Subject: [PATCH] Remove package code path for all parsing failure

Instead of only remove for INSTALL_FAILED_INVALID_APK reason, remove if
it is not a success.

This was introduced at 679bba33 in 2010.

Test: adb shell stop, tamper with an apk in /data, start
      # see bad apk being removed
Bug: 30972906
Change-Id: I8b468958a7547ce2ed030e78356b2ce3ddd3641d
---
 .../core/java/com/android/server/pm/PackageManagerService.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/services/core/java/com/android/server/pm/PackageManagerService.java b/services/core/java/com/android/server/pm/PackageManagerService.java
index bb1f5c02f8643..144f28988a1c7 100644
--- a/services/core/java/com/android/server/pm/PackageManagerService.java
+++ b/services/core/java/com/android/server/pm/PackageManagerService.java
@@ -8429,7 +8429,7 @@ public class PackageManagerService extends IPackageManager.Stub
 
                 // Delete invalid userdata apps
                 if ((scanFlags & SCAN_AS_SYSTEM) == 0 &&
-                        errorCode == PackageManager.INSTALL_FAILED_INVALID_APK) {
+                        errorCode != PackageManager.INSTALL_SUCCEEDED) {
                     logCriticalInfo(Log.WARN,
                             "Deleting invalid package at " + parseResult.scanFile);
                     removeCodePathLI(parseResult.scanFile);