From fc7069c169d4f3e9367d5456f9311e4b30a1d37b Mon Sep 17 00:00:00 2001 From: Alison Cichowlas Date: Fri, 25 Jun 2021 15:44:57 -0400 Subject: [PATCH 1/2] Update Edit icon. Bug: 186719466 Test: icon only, manually verified Change-Id: Idd24fd51fcd5f3b986889bc16bf0eb05507d7ff0 --- .../android/internal/app/ChooserActivity.java | 2 +- core/res/res/drawable/ic_screenshot_edit.xml | 24 +++++++++++++++++++ core/res/res/values/symbols.xml | 1 + 3 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 core/res/res/drawable/ic_screenshot_edit.xml diff --git a/core/java/com/android/internal/app/ChooserActivity.java b/core/java/com/android/internal/app/ChooserActivity.java index 7000ed75d5be9..a6bf3cf9b8066 100644 --- a/core/java/com/android/internal/app/ChooserActivity.java +++ b/core/java/com/android/internal/app/ChooserActivity.java @@ -1186,7 +1186,7 @@ public class ChooserActivity extends ResolverActivity implements final DisplayResolveInfo dri = new DisplayResolveInfo( originalIntent, ri, getString(R.string.screenshot_edit), "", resolveIntent, null); - dri.setDisplayIcon(getDrawable(R.drawable.ic_menu_edit)); + dri.setDisplayIcon(getDrawable(R.drawable.ic_screenshot_edit)); return dri; } diff --git a/core/res/res/drawable/ic_screenshot_edit.xml b/core/res/res/drawable/ic_screenshot_edit.xml new file mode 100644 index 0000000000000..2d9148f90b730 --- /dev/null +++ b/core/res/res/drawable/ic_screenshot_edit.xml @@ -0,0 +1,24 @@ + + + + \ No newline at end of file diff --git a/core/res/res/values/symbols.xml b/core/res/res/values/symbols.xml index ea28215267683..989309b1350c7 100644 --- a/core/res/res/values/symbols.xml +++ b/core/res/res/values/symbols.xml @@ -4161,6 +4161,7 @@ + From b9cfb88d507c68ba5f8379efb384d22879dffcfe Mon Sep 17 00:00:00 2001 From: Alison Cichowlas Date: Fri, 25 Jun 2021 16:28:29 -0400 Subject: [PATCH 2/2] Sharesheet style updates Bug: 178619070 Test: Manual Change-Id: I5bdc1f46c55fdde01ebf0203c13b0af5ec5746b4 --- core/res/res/drawable/chooser_action_button_bg.xml | 5 +++-- core/res/res/layout/chooser_action_button.xml | 4 ++-- core/res/res/layout/chooser_grid.xml | 1 + core/res/res/values/dimens.xml | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/core/res/res/drawable/chooser_action_button_bg.xml b/core/res/res/drawable/chooser_action_button_bg.xml index 18bbd93d1535a..518d51a3f580c 100644 --- a/core/res/res/drawable/chooser_action_button_bg.xml +++ b/core/res/res/drawable/chooser_action_button_bg.xml @@ -23,8 +23,9 @@ android:insetRight="0dp" android:insetBottom="8dp"> - - + + diff --git a/core/res/res/layout/chooser_action_button.xml b/core/res/res/layout/chooser_action_button.xml index def429ecd62b7..2b68cccaf2917 100644 --- a/core/res/res/layout/chooser_action_button.xml +++ b/core/res/res/layout/chooser_action_button.xml @@ -19,13 +19,13 @@ android:paddingStart="12dp" android:paddingEnd="12dp" android:drawablePadding="8dp" - android:textColor="@color/text_color_primary_device_default_light" + android:textColor="?android:attr/textColorPrimary" android:textSize="12sp" android:maxWidth="192dp" android:singleLine="true" android:clickable="true" android:background="@drawable/chooser_action_button_bg" - android:drawableTint="@color/text_color_primary_device_default_light" + android:drawableTint="?android:attr/textColorPrimary" android:drawableTintMode="src_in" style="?android:attr/borderlessButtonStyle" /> diff --git a/core/res/res/layout/chooser_grid.xml b/core/res/res/layout/chooser_grid.xml index 10683b189fc53..90caaccfbff4f 100644 --- a/core/res/res/layout/chooser_grid.xml +++ b/core/res/res/layout/chooser_grid.xml @@ -51,6 +51,7 @@ android:paddingBottom="@dimen/chooser_view_spacing" android:paddingLeft="24dp" android:paddingRight="24dp" + android:visibility="gone" android:layout_below="@id/drag" android:layout_centerHorizontal="true"/> diff --git a/core/res/res/values/dimens.xml b/core/res/res/values/dimens.xml index ea93520502d5e..de7a1175b4a30 100644 --- a/core/res/res/values/dimens.xml +++ b/core/res/res/values/dimens.xml @@ -886,7 +886,7 @@ 48dp - 8dp + 16dp 25dp 18dp 16dp