From 7bba64785a35cceaa96271d6bbb998ad2eb5564a Mon Sep 17 00:00:00 2001 From: Bill Lin Date: Tue, 17 May 2022 16:13:12 +0800 Subject: [PATCH] Avoid warning log from InteractionJankMonitor in VolumeDialogImpl the two intents ACTION_CLOSE_SYSTEM_DIALOGS, ACTION_SCREEN_OFF have a race in VolumeDialogImpl, so the JankLinster may begin a tracing on a DialogView which has detachted from window. Test: Manually press VolumeKey and Press power key to screen off InteractionJankMonitor warning log should not showing. Bug: 232066671 Change-Id: Ic8f973372bbe1bda0f8dbab58d99269a2d766e46 --- .../src/com/android/systemui/volume/VolumeDialogImpl.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/SystemUI/src/com/android/systemui/volume/VolumeDialogImpl.java b/packages/SystemUI/src/com/android/systemui/volume/VolumeDialogImpl.java index cf0d0238b3cc2..51f0b7469f835 100644 --- a/packages/SystemUI/src/com/android/systemui/volume/VolumeDialogImpl.java +++ b/packages/SystemUI/src/com/android/systemui/volume/VolumeDialogImpl.java @@ -1271,6 +1271,10 @@ public class VolumeDialogImpl implements VolumeDialog, return new Animator.AnimatorListener() { @Override public void onAnimationStart(@NonNull Animator animation) { + if (!v.isAttachedToWindow()) { + if (D.BUG) Log.d(TAG, "onAnimationStart view do not attached to window:" + v); + return; + } mInteractionJankMonitor.begin(Builder.withView(CUJ_VOLUME_CONTROL, v).setTag(type) .setTimeout(timeout)); }