From 8def74de33b197c0c5ec8774576b1d71c7ec4f1b Mon Sep 17 00:00:00 2001 From: ztenghui Date: Wed, 1 Oct 2014 16:10:16 -0700 Subject: [PATCH] + correcting shadow visual appearance (b/17610926) + adjusting spot and ambient shadow opacity constants to achieve desired appearance + reducing ambient scale ratio back to 1.0 to address over-lightening at higher elevations + partially revert ag/546290 Change-Id: I9d7f664f73a7b9b83df73b739103c97054bd4f6e --- core/res/res/values/dimens.xml | 4 ++-- libs/hwui/ShadowTessellator.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/res/res/values/dimens.xml b/core/res/res/values/dimens.xml index 824ed9efb6771..26d313371ae1a 100644 --- a/core/res/res/values/dimens.xml +++ b/core/res/res/values/dimens.xml @@ -412,7 +412,7 @@ -200dp 800dp 800dp - 0.047 - 0.098 + 0.075 + 0.15 diff --git a/libs/hwui/ShadowTessellator.cpp b/libs/hwui/ShadowTessellator.cpp index 35cc7a4fd69dd..c1ffa0ab4807f 100644 --- a/libs/hwui/ShadowTessellator.cpp +++ b/libs/hwui/ShadowTessellator.cpp @@ -37,7 +37,7 @@ void ShadowTessellator::tessellateAmbientShadow(bool isCasterOpaque, // A bunch of parameters to tweak the shadow. // TODO: Allow some of these changable by debug settings or APIs. - float heightFactor = 1.0f / 86; + float heightFactor = 1.0f / 128; const float geomFactor = 64; Caches& caches = Caches::getInstance();