From 034c4b84283878915d505d31bb080da42c33d7c7 Mon Sep 17 00:00:00 2001 From: Prabir Pradhan Date: Wed, 25 Aug 2021 13:12:31 -0700 Subject: [PATCH 1/2] Use pointer source in MotionEventTest#testEventRotation Only pointer sources have event rotation applied to them by MotionEvent. We need to a pointer source like SOURCE_TOUCHSCREEN to ensure the event is rotated as expected. Bug: 179274888 Test: atest MotionEventTest Change-Id: I610858c50bfbd42ecfeb326d162b17a3cb93f544 --- core/tests/coretests/src/android/view/MotionEventTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/core/tests/coretests/src/android/view/MotionEventTest.java b/core/tests/coretests/src/android/view/MotionEventTest.java index b3450de800920..d91836b7e018c 100644 --- a/core/tests/coretests/src/android/view/MotionEventTest.java +++ b/core/tests/coretests/src/android/view/MotionEventTest.java @@ -174,6 +174,7 @@ public class MotionEventTest { public void testEventRotation() { final MotionEvent event = MotionEvent.obtain(0 /* downTime */, 0 /* eventTime */, ACTION_DOWN, 30 /* x */, 50 /* y */, 0 /* metaState */); + event.setSource(InputDevice.SOURCE_TOUCHSCREEN); MotionEvent rot90 = MotionEvent.obtain(event); rot90.transform(MotionEvent.createRotateMatrix(/* 90 deg */1, 1000, 600)); assertEquals(50, (int) rot90.getX()); From 5fde5bf7d91b59e9037255e34e14f907ece0ff05 Mon Sep 17 00:00:00 2001 From: Prabir Pradhan Date: Mon, 20 Sep 2021 09:24:48 -0700 Subject: [PATCH 2/2] Add input tests in FrameworksCoreTests to presubmit Bug: None Test: presubmit Change-Id: I829278acda2374e56f414ee378121b80e652a525 --- core/tests/coretests/src/android/view/KeyEventTest.java | 2 ++ core/tests/coretests/src/android/view/MotionEventTest.java | 2 ++ core/tests/coretests/src/android/view/VerifiedKeyEventTest.kt | 2 ++ .../tests/coretests/src/android/view/VerifiedMotionEventTest.kt | 2 ++ 4 files changed, 8 insertions(+) diff --git a/core/tests/coretests/src/android/view/KeyEventTest.java b/core/tests/coretests/src/android/view/KeyEventTest.java index 98ab592e344fd..bbb25a37dd0b5 100644 --- a/core/tests/coretests/src/android/view/KeyEventTest.java +++ b/core/tests/coretests/src/android/view/KeyEventTest.java @@ -22,6 +22,7 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import android.os.Parcel; +import android.platform.test.annotations.Presubmit; import androidx.test.ext.junit.runners.AndroidJUnit4; import androidx.test.filters.SmallTest; @@ -34,6 +35,7 @@ import java.util.Set; @SmallTest @RunWith(AndroidJUnit4.class) +@Presubmit public class KeyEventTest { private static final int DOWN_TIME = 50; diff --git a/core/tests/coretests/src/android/view/MotionEventTest.java b/core/tests/coretests/src/android/view/MotionEventTest.java index d91836b7e018c..7f7a7aaf73058 100644 --- a/core/tests/coretests/src/android/view/MotionEventTest.java +++ b/core/tests/coretests/src/android/view/MotionEventTest.java @@ -26,6 +26,7 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNull; +import android.platform.test.annotations.Presubmit; import android.view.MotionEvent.PointerCoords; import android.view.MotionEvent.PointerProperties; @@ -40,6 +41,7 @@ import java.util.Set; @RunWith(AndroidJUnit4.class) @SmallTest +@Presubmit public class MotionEventTest { private static final int ID_SOURCE_MASK = 0x3 << 30; diff --git a/core/tests/coretests/src/android/view/VerifiedKeyEventTest.kt b/core/tests/coretests/src/android/view/VerifiedKeyEventTest.kt index 531d55d7738aa..86ff2da38161e 100644 --- a/core/tests/coretests/src/android/view/VerifiedKeyEventTest.kt +++ b/core/tests/coretests/src/android/view/VerifiedKeyEventTest.kt @@ -19,6 +19,7 @@ package android.view import android.view.InputDevice.SOURCE_KEYBOARD import android.view.KeyEvent.ACTION_DOWN import android.os.Parcel +import android.platform.test.annotations.Presubmit import androidx.test.ext.junit.runners.AndroidJUnit4 import androidx.test.filters.SmallTest @@ -30,6 +31,7 @@ import org.junit.Test @RunWith(AndroidJUnit4::class) @SmallTest +@Presubmit class VerifiedKeyEventTest { @Test diff --git a/core/tests/coretests/src/android/view/VerifiedMotionEventTest.kt b/core/tests/coretests/src/android/view/VerifiedMotionEventTest.kt index 29ad0aa43672b..97870eee69429 100644 --- a/core/tests/coretests/src/android/view/VerifiedMotionEventTest.kt +++ b/core/tests/coretests/src/android/view/VerifiedMotionEventTest.kt @@ -23,6 +23,7 @@ import android.view.MotionEvent.FLAG_WINDOW_IS_OBSCURED import android.view.MotionEvent.FLAG_WINDOW_IS_PARTIALLY_OBSCURED import android.view.MotionEvent.FLAG_TAINTED import android.os.Parcel +import android.platform.test.annotations.Presubmit import androidx.test.ext.junit.runners.AndroidJUnit4 import androidx.test.filters.SmallTest @@ -35,6 +36,7 @@ import org.junit.Test @RunWith(AndroidJUnit4::class) @SmallTest +@Presubmit class VerifiedMotionEventTest { @Test