From b659adb3f3d13049ca1c08fcec2d419ffd7a386b Mon Sep 17 00:00:00 2001 From: Felipe Leme Date: Thu, 18 Jan 2018 15:21:36 -0800 Subject: [PATCH] Fixed AUTOFILL_UI_LATENCY metric. This metric was using the RESERVED_FOR_LOGBUILDER_COUNTER and hence was not being picked up. Bug: 71863561 Fixes: 72175011 Test: adb shell logcat -b events | grep sysui | grep 1136 Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases Change-Id: I34f701ff5336a413477fd14172d16d8d1e5403ad --- proto/src/metrics_constants.proto | 6 +++++- .../autofill/java/com/android/server/autofill/Session.java | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/proto/src/metrics_constants.proto b/proto/src/metrics_constants.proto index fef8696ec5377..1070e4e6f6396 100644 --- a/proto/src/metrics_constants.proto +++ b/proto/src/metrics_constants.proto @@ -4545,7 +4545,8 @@ message MetricsEvent { // OS: O MR AUTOFILL_SERVICE_DISABLED_SELF = 1135; - // Counter showing how long it took (in ms) to show the autofill UI after a field was focused + // Reports how long it took to show the autofill UI after a field was focused + // Tag FIELD_AUTOFILL_DURATION: Duration in ms // Tag FIELD_AUTOFILL_SERVICE: Package of service that processed the request // Package: Package of the autofill service // OS: O MR @@ -4584,6 +4585,9 @@ message MetricsEvent { // logged when we cancel an app transition. APP_TRANSITION_CANCELLED = 1144; + // Tag of a field representing a duration on autofill-related metrics. + FIELD_AUTOFILL_DURATION = 1145; + // ---- End O-MR1 Constants, all O-MR1 constants go above this line ---- // Add new aosp constants above this line. diff --git a/services/autofill/java/com/android/server/autofill/Session.java b/services/autofill/java/com/android/server/autofill/Session.java index c5cf970eab79b..1f0e51c694aaa 100644 --- a/services/autofill/java/com/android/server/autofill/Session.java +++ b/services/autofill/java/com/android/server/autofill/Session.java @@ -1397,7 +1397,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState mUiLatencyHistory.log(historyLog.toString()); final LogMaker metricsLog = newLogMaker(MetricsEvent.AUTOFILL_UI_LATENCY) - .setCounterValue((int) duration); + .addTaggedData(MetricsEvent.FIELD_AUTOFILL_DURATION, duration); mMetricsLogger.write(metricsLog); } }