From 72dd460fa0e6a587487714d37b8a8c90e8f0b428 Mon Sep 17 00:00:00 2001 From: Michal Brzezinski Date: Wed, 15 Feb 2023 17:07:05 +0000 Subject: [PATCH] Add logging for mQsExpandImmediate changes I suspect reason for QS sometimes disappearing in split shade might have something to do with this value not being set correctly. Also it's not changing that often - twice per expand/collapse - so should be good to log. Bug: 219589379 Test: just adding logs Change-Id: Ic6ef9416c7198109905cfdf16ce4e998cd398f80 --- .../systemui/shade/QuickSettingsController.java | 1 + .../src/com/android/systemui/shade/ShadeLogger.kt | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/packages/SystemUI/src/com/android/systemui/shade/QuickSettingsController.java b/packages/SystemUI/src/com/android/systemui/shade/QuickSettingsController.java index c0ef4c1a872ae..0b48aad50ad4c 100644 --- a/packages/SystemUI/src/com/android/systemui/shade/QuickSettingsController.java +++ b/packages/SystemUI/src/com/android/systemui/shade/QuickSettingsController.java @@ -835,6 +835,7 @@ public class QuickSettingsController { @VisibleForTesting void setExpandImmediate(boolean expandImmediate) { if (expandImmediate != mExpandImmediate) { + mShadeLog.logQsExpandImmediateChanged(expandImmediate); mExpandImmediate = expandImmediate; mShadeExpansionStateManager.notifyExpandImmediateChange(expandImmediate); } diff --git a/packages/SystemUI/src/com/android/systemui/shade/ShadeLogger.kt b/packages/SystemUI/src/com/android/systemui/shade/ShadeLogger.kt index b28509e8fbf5b..aa8c5b65e0fed 100644 --- a/packages/SystemUI/src/com/android/systemui/shade/ShadeLogger.kt +++ b/packages/SystemUI/src/com/android/systemui/shade/ShadeLogger.kt @@ -150,6 +150,17 @@ class ShadeLogger @Inject constructor(@ShadeLog private val buffer: LogBuffer) { ) } + fun logQsExpandImmediateChanged(newValue: Boolean) { + buffer.log( + TAG, + LogLevel.VERBOSE, + { + bool1 = newValue + }, + { "qsExpandImmediate=$bool1" } + ) + } + fun logQsExpansionChanged( message: String, qsExpanded: Boolean,