Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes broadcast filtering for multi-user sys apps

Browse Source 
This change fixes a bug caused by the assumption that
FIRST_APPLICATION_UID is just that and that we should not treat UIDs
with an APP_ID < FIRST_APPLICATION_UID in secondary users as system
users that can see all packages.

Test: atest AppsFilterTest AppEnumerationTests
Test: manual; enable/disable apps in work profile
Fixes: 157690238
Change-Id: I0aab78954222f0d1cf86a83375a8d0669025144a
This commit is contained in:
Patrick Baumann
2020-06-12 09:25:10 -07:00
parent d91f4d23cd
commit 5dec234870
3 changed files with 27 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
services/core/java/com/android/server/am/ActivityManagerService.java
View File

@@ -15793,9 +15793,10 @@ public class ActivityManagerService extends IActivityManager.Stub
}
if (receivers != null && broadcastWhitelist != null) {
for (int i = receivers.size() - 1; i >= 0; i--) {
final int uid = receivers.get(i).activityInfo.applicationInfo.uid;
if (uid >= Process.FIRST_APPLICATION_UID
&& Arrays.binarySearch(broadcastWhitelist, UserHandle.getAppId(uid)) < 0) {
final int receiverAppId = UserHandle.getAppId(
receivers.get(i).activityInfo.applicationInfo.uid);
if (receiverAppId >= Process.FIRST_APPLICATION_UID
&& Arrays.binarySearch(broadcastWhitelist, receiverAppId) < 0) {
receivers.remove(i);
}
}
@@ -16441,9 +16442,9 @@ public class ActivityManagerService extends IActivityManager.Stub
// if a uid whitelist was provided, remove anything in the application space that wasn't
// in it.
for (int i = registeredReceivers.size() - 1; i >= 0; i--) {
final int uid = registeredReceivers.get(i).owningUid;
if (uid >= Process.FIRST_APPLICATION_UID
&& Arrays.binarySearch(broadcastWhitelist, UserHandle.getAppId(uid)) < 0) {
final int owningAppId = UserHandle.getAppId(registeredReceivers.get(i).owningUid);
if (owningAppId >= Process.FIRST_APPLICATION_UID
&& Arrays.binarySearch(broadcastWhitelist, owningAppId) < 0) {
registeredReceivers.remove(i);
}
}

7
services/core/java/com/android/server/pm/AppsFilter.java
View File

@@ -843,8 +843,9 @@ public class AppsFilter {
PackageSetting targetPkgSetting, int userId) {
Trace.traceBegin(TRACE_TAG_PACKAGE_MANAGER, "shouldFilterApplication");
try {
if (callingUid < Process.FIRST_APPLICATION_UID
|| UserHandle.getAppId(callingUid) == targetPkgSetting.appId) {
int callingAppId = UserHandle.getAppId(callingUid);
if (callingAppId < Process.FIRST_APPLICATION_UID
|| callingAppId == targetPkgSetting.appId) {
return false;
}
if (mShouldFilterCache != null) { // use cache
@@ -869,7 +870,7 @@ public class AppsFilter {
return false;
}
}
if (DEBUG_LOGGING || mFeatureConfig.isLoggingEnabled(UserHandle.getAppId(callingUid))) {
if (DEBUG_LOGGING || mFeatureConfig.isLoggingEnabled(callingAppId)) {
log(callingSetting, targetPkgSetting, "BLOCKED");
}
return !DEBUG_ALLOW_ALL;

16
services/tests/servicestests/src/com/android/server/pm/AppsFilterTest.java
View File

@@ -512,6 +512,22 @@ public class AppsFilterTest {
null, target, SYSTEM_USER));
}
@Test
public void testSystemUidSecondaryUser_DoesntFilter() throws Exception {
final AppsFilter appsFilter =
new AppsFilter(mStateProvider, mFeatureConfigMock, new String[]{}, false, null);
simulateAddBasicAndroid(appsFilter);
appsFilter.onSystemReady();
PackageSetting target = simulateAddPackage(appsFilter,
pkg("com.some.package"), DUMMY_TARGET_APPID);
assertFalse(appsFilter.shouldFilterApplication(0, null, target, SECONDARY_USER));
assertFalse(appsFilter.shouldFilterApplication(
UserHandle.getUid(SECONDARY_USER, Process.FIRST_APPLICATION_UID - 1),
null, target, SECONDARY_USER));
}
@Test
public void testNonSystemUid_NoCallingSetting_Filters() throws Exception {
final AppsFilter appsFilter =