From 57efcffc7f7290a5510bd1f4f1880a32cc37ad6d Mon Sep 17 00:00:00 2001 From: John Reck Date: Thu, 15 Sep 2011 13:51:52 -0700 Subject: [PATCH] Fix text selection drawing on SW Bug: 5312770 Helps if you actually draw stuff... Change-Id: I5ab8cd0726cac77a91fb476c7db0873132ba91d9 --- core/java/android/webkit/WebView.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/core/java/android/webkit/WebView.java b/core/java/android/webkit/WebView.java index 2f7347458d8f5..7d4e8a226101d 100644 --- a/core/java/android/webkit/WebView.java +++ b/core/java/android/webkit/WebView.java @@ -4436,6 +4436,7 @@ public class WebView extends AbsoluteLayout mHeldMotionless = MOTIONLESS_PENDING; } } + int saveCount = canvas.save(); if (animateZoom) { mZoomManager.animateZoom(canvas); } else if (!canvas.isHardwareAccelerated()) { @@ -4486,10 +4487,6 @@ public class WebView extends AbsoluteLayout nativeUseHardwareAccelSkia(mHardwareAccelSkia); } - if (mSelectingText && USE_JAVA_TEXT_SELECTION) { - drawTextSelectionHandles(canvas); - } - } else { DrawFilter df = null; if (mZoomManager.isZoomAnimating() || UIAnimationsRunning) { @@ -4507,6 +4504,11 @@ public class WebView extends AbsoluteLayout } } + canvas.restoreToCount(saveCount); + if (mSelectingText && USE_JAVA_TEXT_SELECTION) { + drawTextSelectionHandles(canvas); + } + if (extras == DRAW_EXTRAS_CURSOR_RING) { if (mTouchMode == TOUCH_SHORTPRESS_START_MODE) { mTouchMode = TOUCH_SHORTPRESS_MODE;