Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Limit dotProduct value to 1.0f, so acosf would not return NaN." into mnc-dev

Browse Source
This commit is contained in:
Tenghui Zhu
2015-06-25 21:45:31 +00:00
committed by Android (Google) Code Review
parent fd70942147 1240752c44
commit 5daee1dc27
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
libs/hwui/ShadowTessellator.cpp
View File

@@ -21,6 +21,7 @@
#include <utils/Log.h> #include <utils/Log.h>
#include <utils/Trace.h> #include <utils/Trace.h>
#include <utils/Vector.h> #include <utils/Vector.h>
#include <utils/MathUtils.h>
#include "AmbientShadow.h" #include "AmbientShadow.h"
#include "Properties.h" #include "Properties.h"
@@ -172,6 +173,8 @@ int ShadowTessellator::getExtraVertexNumber(const Vector2& vector1,
// acos( ) --- [0, M_PI] // acos( ) --- [0, M_PI]
// floor(...) --- [0, EXTRA_VERTEX_PER_PI] // floor(...) --- [0, EXTRA_VERTEX_PER_PI]
float dotProduct = vector1.dot(vector2); float dotProduct = vector1.dot(vector2);
// make sure that dotProduct value is in acsof input range [-1, 1]
dotProduct = MathUtils::clamp(dotProduct, -1.0f, 1.0f);
// TODO: Use look up table for the dotProduct to extraVerticesNumber // TODO: Use look up table for the dotProduct to extraVerticesNumber
// computation, if needed. // computation, if needed.
float angle = acosf(dotProduct); float angle = acosf(dotProduct);