From 066a544d060bca635674ccfd5e7520b2ae93e9b3 Mon Sep 17 00:00:00 2001 From: jasonwshsu Date: Mon, 20 Apr 2020 19:56:27 +0800 Subject: [PATCH] Return empty for empty string in AccessibilityShortcutInfro#loadHtmlDescription * Follow the behavior to return empty if given string is empty - AccessibilityServiceInfo#loadDescription - AccessibilityServiceInfo#loadHtmlDescription - AccessibilityShortcutInfo#loadDescription - AccessibilityShortcutInfo#loadHtmlDescription Bug: 154092127 Test: manual test Change-Id: I77f455945c569c81cb00127a7913bae4db1b3d1c --- .../accessibilityservice/AccessibilityShortcutInfo.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/core/java/android/accessibilityservice/AccessibilityShortcutInfo.java b/core/java/android/accessibilityservice/AccessibilityShortcutInfo.java index 9a3dad2eb92f2..d70a3c9d1aac0 100644 --- a/core/java/android/accessibilityservice/AccessibilityShortcutInfo.java +++ b/core/java/android/accessibilityservice/AccessibilityShortcutInfo.java @@ -30,7 +30,6 @@ import android.content.res.Resources; import android.content.res.TypedArray; import android.content.res.XmlResourceParser; import android.graphics.drawable.Drawable; -import android.text.TextUtils; import android.util.AttributeSet; import android.util.Xml; @@ -243,7 +242,10 @@ public final class AccessibilityShortcutInfo { public String loadHtmlDescription(@NonNull PackageManager packageManager) { final String htmlDescription = loadResourceString(packageManager, mActivityInfo, mHtmlDescriptionRes); - return TextUtils.isEmpty(htmlDescription) ? null : getFilteredHtmlText(htmlDescription); + if (htmlDescription != null) { + return getFilteredHtmlText(htmlDescription); + } + return null; } /**