From 5c3734456e35de1ea56f890537f9eebf5f2ec699 Mon Sep 17 00:00:00 2001 From: Andrew Sapperstein Date: Sun, 12 Jun 2016 13:17:16 -0700 Subject: [PATCH] Update System UI to use theme colors. Instead of using hardcoded values, use colorPrimary, colorAccent, etc to style system UI. Required setting a theme on several views to get the proper accent color in the right place. Deletes a lot of hard-coded colors from the app. Deletes an unused view: StatusBarHeaderView BUG: 28625050 BUG: 29003410 BUG: 28625105 Change-Id: I46cd8eba7cf5afdab53c7882aa4aac5af46772a9 --- .../res/res/values/themes_device_defaults.xml | 11 + .../src/com/android/settingslib/Utils.java | 10 + .../res/color/notification_guts_buttons.xml | 2 +- .../res/color/qs_detail_progress_track.xml | 20 + .../res/color/qs_user_detail_avatar_frame.xml | 2 +- .../res/color/qs_user_detail_name.xml | 2 +- ...reen_pinning_nav_icon_highlight_outer.xml} | 13 +- .../drawable/brightness_mirror_background.xml | 2 +- .../res/drawable/ic_brightness_thumb.xml | 2 +- .../res/drawable/qs_background_primary.xml | 2 +- .../res/drawable/qs_customizer_background.xml | 2 +- .../res/drawable/qs_detail_background.xml | 2 +- .../SystemUI/res/drawable/quick_header_bg.xml | 2 +- .../res/drawable/screen_pinning_bg_circ.xml | 2 +- .../res/drawable/switchbar_background.xml | 2 +- .../res/drawable/volume_dialog_background.xml | 2 +- .../zen_introduction_message_background.xml | 2 +- .../SystemUI/res/layout/notification_guts.xml | 7 +- .../res/layout/screen_pinning_request.xml | 5 +- .../layout/screen_pinning_request_buttons.xml | 5 +- .../screen_pinning_request_buttons_land.xml | 7 +- .../screen_pinning_request_land_phone.xml | 3 +- .../screen_pinning_request_text_area.xml | 4 +- .../res/layout/status_bar_expanded_header.xml | 195 ---- packages/SystemUI/res/layout/switch_bar.xml | 6 +- .../SystemUI/res/layout/volume_zen_footer.xml | 2 +- .../SystemUI/res/layout/zen_mode_panel.xml | 3 +- packages/SystemUI/res/values/colors.xml | 18 +- packages/SystemUI/res/values/styles.xml | 30 +- .../android/systemui/qs/DataUsageGraph.java | 3 +- .../qs/tiles/DataUsageDetailView.java | 7 +- .../systemui/statusbar/KeyboardShortcuts.java | 5 +- .../systemui/statusbar/NotificationGuts.java | 2 +- .../statusbar/phone/StatusBarHeaderView.java | 842 ------------------ .../android/systemui/volume/VolumeDialog.java | 3 +- 35 files changed, 109 insertions(+), 1118 deletions(-) create mode 100644 packages/SystemUI/res/color/qs_detail_progress_track.xml rename packages/SystemUI/res/{drawable/fab_background.xml => color/screen_pinning_nav_icon_highlight_outer.xml} (68%) delete mode 100644 packages/SystemUI/res/layout/status_bar_expanded_header.xml delete mode 100644 packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarHeaderView.java diff --git a/core/res/res/values/themes_device_defaults.xml b/core/res/res/values/themes_device_defaults.xml index e5b6c7830adfc..273d93f61b32d 100644 --- a/core/res/res/values/themes_device_defaults.xml +++ b/core/res/res/values/themes_device_defaults.xml @@ -753,4 +753,15 @@ easier. + + + diff --git a/packages/SettingsLib/src/com/android/settingslib/Utils.java b/packages/SettingsLib/src/com/android/settingslib/Utils.java index d98f1a4740ad4..7993131e60ec5 100644 --- a/packages/SettingsLib/src/com/android/settingslib/Utils.java +++ b/packages/SettingsLib/src/com/android/settingslib/Utils.java @@ -1,5 +1,6 @@ package com.android.settingslib; +import android.annotation.ColorInt; import android.content.Context; import android.content.Intent; import android.content.pm.PackageInfo; @@ -8,6 +9,7 @@ import android.content.pm.PackageManager.NameNotFoundException; import android.content.pm.UserInfo; import android.content.pm.Signature; import android.content.res.Resources; +import android.content.res.TypedArray; import android.graphics.Bitmap; import android.graphics.BitmapFactory; import android.graphics.drawable.Drawable; @@ -154,6 +156,14 @@ public class Utils { return statusString; } + @ColorInt + public static int getColorAccent(Context context) { + TypedArray ta = context.obtainStyledAttributes(new int[]{android.R.attr.colorAccent}); + @ColorInt int colorAccent = ta.getColor(0, 0); + ta.recycle(); + return colorAccent; + } + /** * Determine whether a package is a "system package", in which case certain things (like * disabling notifications or disabling the package altogether) should be disallowed. diff --git a/packages/SystemUI/res/color/notification_guts_buttons.xml b/packages/SystemUI/res/color/notification_guts_buttons.xml index c211e438174a3..3b8d59bae7445 100644 --- a/packages/SystemUI/res/color/notification_guts_buttons.xml +++ b/packages/SystemUI/res/color/notification_guts_buttons.xml @@ -1,7 +1,7 @@ + android:color="?android:attr/colorAccent" /> \ No newline at end of file diff --git a/packages/SystemUI/res/color/qs_detail_progress_track.xml b/packages/SystemUI/res/color/qs_detail_progress_track.xml new file mode 100644 index 0000000000000..c56382e6047f6 --- /dev/null +++ b/packages/SystemUI/res/color/qs_detail_progress_track.xml @@ -0,0 +1,20 @@ + + + + + + diff --git a/packages/SystemUI/res/color/qs_user_detail_avatar_frame.xml b/packages/SystemUI/res/color/qs_user_detail_avatar_frame.xml index 20251c2fedc02..344859c27e34b 100644 --- a/packages/SystemUI/res/color/qs_user_detail_avatar_frame.xml +++ b/packages/SystemUI/res/color/qs_user_detail_avatar_frame.xml @@ -17,6 +17,6 @@ --> - + \ No newline at end of file diff --git a/packages/SystemUI/res/color/qs_user_detail_name.xml b/packages/SystemUI/res/color/qs_user_detail_name.xml index 35c7a4fe754bc..e262209a82c36 100644 --- a/packages/SystemUI/res/color/qs_user_detail_name.xml +++ b/packages/SystemUI/res/color/qs_user_detail_name.xml @@ -17,7 +17,7 @@ --> - + \ No newline at end of file diff --git a/packages/SystemUI/res/drawable/fab_background.xml b/packages/SystemUI/res/color/screen_pinning_nav_icon_highlight_outer.xml similarity index 68% rename from packages/SystemUI/res/drawable/fab_background.xml rename to packages/SystemUI/res/color/screen_pinning_nav_icon_highlight_outer.xml index 7f23f2b63e419..5370f7afb5f5a 100644 --- a/packages/SystemUI/res/drawable/fab_background.xml +++ b/packages/SystemUI/res/color/screen_pinning_nav_icon_highlight_outer.xml @@ -1,5 +1,5 @@ - - - - - - - - + + + diff --git a/packages/SystemUI/res/drawable/brightness_mirror_background.xml b/packages/SystemUI/res/drawable/brightness_mirror_background.xml index e901e40fe23d2..0c69d89b47097 100644 --- a/packages/SystemUI/res/drawable/brightness_mirror_background.xml +++ b/packages/SystemUI/res/drawable/brightness_mirror_background.xml @@ -15,5 +15,5 @@ ~ limitations under the License --> - + diff --git a/packages/SystemUI/res/drawable/ic_brightness_thumb.xml b/packages/SystemUI/res/drawable/ic_brightness_thumb.xml index dc978fe0d48dd..24ac0184a5512 100644 --- a/packages/SystemUI/res/drawable/ic_brightness_thumb.xml +++ b/packages/SystemUI/res/drawable/ic_brightness_thumb.xml @@ -20,7 +20,7 @@ Copyright (C) 2014 The Android Open Source Project android:viewportHeight="24.0"> + android:fillColor="?android:attr/colorPrimary" /> diff --git a/packages/SystemUI/res/drawable/qs_background_primary.xml b/packages/SystemUI/res/drawable/qs_background_primary.xml index 1bf7d4c952167..8ea9e06391088 100644 --- a/packages/SystemUI/res/drawable/qs_background_primary.xml +++ b/packages/SystemUI/res/drawable/qs_background_primary.xml @@ -15,6 +15,6 @@ --> - + diff --git a/packages/SystemUI/res/drawable/qs_customizer_background.xml b/packages/SystemUI/res/drawable/qs_customizer_background.xml index d90f820f5d4db..12d8016bf6a0c 100644 --- a/packages/SystemUI/res/drawable/qs_customizer_background.xml +++ b/packages/SystemUI/res/drawable/qs_customizer_background.xml @@ -15,5 +15,5 @@ --> - + diff --git a/packages/SystemUI/res/drawable/qs_detail_background.xml b/packages/SystemUI/res/drawable/qs_detail_background.xml index 692cd441c88d1..84c793f6abd68 100644 --- a/packages/SystemUI/res/drawable/qs_detail_background.xml +++ b/packages/SystemUI/res/drawable/qs_detail_background.xml @@ -15,5 +15,5 @@ Copyright (C) 2014 The Android Open Source Project --> - + \ No newline at end of file diff --git a/packages/SystemUI/res/drawable/quick_header_bg.xml b/packages/SystemUI/res/drawable/quick_header_bg.xml index d45d673d8bca3..920e6f5ef0867 100644 --- a/packages/SystemUI/res/drawable/quick_header_bg.xml +++ b/packages/SystemUI/res/drawable/quick_header_bg.xml @@ -17,5 +17,5 @@ - + diff --git a/packages/SystemUI/res/drawable/screen_pinning_bg_circ.xml b/packages/SystemUI/res/drawable/screen_pinning_bg_circ.xml index 354b8bd7607b6..1303bdb00a31b 100644 --- a/packages/SystemUI/res/drawable/screen_pinning_bg_circ.xml +++ b/packages/SystemUI/res/drawable/screen_pinning_bg_circ.xml @@ -19,7 +19,7 @@ - + - + diff --git a/packages/SystemUI/res/drawable/volume_dialog_background.xml b/packages/SystemUI/res/drawable/volume_dialog_background.xml index e98bfb8d09f6b..d6adea9924569 100644 --- a/packages/SystemUI/res/drawable/volume_dialog_background.xml +++ b/packages/SystemUI/res/drawable/volume_dialog_background.xml @@ -14,5 +14,5 @@ limitations under the License. --> - + \ No newline at end of file diff --git a/packages/SystemUI/res/drawable/zen_introduction_message_background.xml b/packages/SystemUI/res/drawable/zen_introduction_message_background.xml index 352fb57bb2b99..e5b41a3fb44cb 100644 --- a/packages/SystemUI/res/drawable/zen_introduction_message_background.xml +++ b/packages/SystemUI/res/drawable/zen_introduction_message_background.xml @@ -17,6 +17,6 @@ - + \ No newline at end of file diff --git a/packages/SystemUI/res/layout/notification_guts.xml b/packages/SystemUI/res/layout/notification_guts.xml index d09c42b8a8c2d..e84ed23fbc868 100644 --- a/packages/SystemUI/res/layout/notification_guts.xml +++ b/packages/SystemUI/res/layout/notification_guts.xml @@ -26,7 +26,8 @@ android:orientation="vertical" android:paddingStart="@*android:dimen/notification_content_margin_start" android:paddingEnd="8dp" - android:background="@color/notification_guts_bg_color"> + android:background="@color/notification_guts_bg_color" + android:theme="@*android:style/Theme.DeviceDefault.Light"> diff --git a/packages/SystemUI/res/layout/screen_pinning_request.xml b/packages/SystemUI/res/layout/screen_pinning_request.xml index fea45cc099cf2..d55ba9445bdef 100644 --- a/packages/SystemUI/res/layout/screen_pinning_request.xml +++ b/packages/SystemUI/res/layout/screen_pinning_request.xml @@ -21,7 +21,8 @@ android:layout_height="wrap_content" android:gravity="bottom|center_horizontal" android:layoutDirection="ltr" - android:orientation="vertical" > + android:orientation="vertical" + android:theme="@android:style/Theme.DeviceDefault.Light"> + android:background="?android:attr/colorAccent" /> + android:background="?android:attr/colorAccent"> + android:paddingEnd="@dimen/screen_pinning_request_frame_padding" + android:theme="@*android:style/ThemeOverlay.DeviceDefault.Accent"> + android:background="?android:attr/colorAccent" + android:orientation="vertical"> + android:layout_weight="0" + android:theme="@*android:style/ThemeOverlay.DeviceDefault.Accent"> + android:orientation="horizontal" + android:theme="@android:style/Theme.DeviceDefault.Light"> + android:background="?android:attr/colorAccent" + android:gravity="center_vertical"> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/packages/SystemUI/res/layout/switch_bar.xml b/packages/SystemUI/res/layout/switch_bar.xml index f98de96a66f97..41cdb78392a9e 100644 --- a/packages/SystemUI/res/layout/switch_bar.xml +++ b/packages/SystemUI/res/layout/switch_bar.xml @@ -22,7 +22,8 @@ android:paddingStart="16dp" android:paddingEnd="16dp" android:clickable="true" - android:gravity="center"> + android:gravity="center" + android:theme="@*android:style/ThemeOverlay.DeviceDefault.Accent"> + android:background="@null" /> diff --git a/packages/SystemUI/res/layout/volume_zen_footer.xml b/packages/SystemUI/res/layout/volume_zen_footer.xml index f30023dc8ef47..ea26bba89432f 100644 --- a/packages/SystemUI/res/layout/volume_zen_footer.xml +++ b/packages/SystemUI/res/layout/volume_zen_footer.xml @@ -78,7 +78,7 @@ android:paddingStart="15dp" android:paddingEnd="15dp" android:text="@string/volume_zen_end_now" - android:textColor="@color/system_accent_color" + android:textColor="?android:attr/colorAccent" android:textAppearance="@style/TextAppearance.QS.DetailButton" /> \ No newline at end of file diff --git a/packages/SystemUI/res/layout/zen_mode_panel.xml b/packages/SystemUI/res/layout/zen_mode_panel.xml index 906b8679931bd..c0be6762e4ed2 100644 --- a/packages/SystemUI/res/layout/zen_mode_panel.xml +++ b/packages/SystemUI/res/layout/zen_mode_panel.xml @@ -40,7 +40,8 @@ android:layout_marginEnd="16dp" android:paddingTop="8dp" android:paddingBottom="8dp" - android:background="@drawable/zen_introduction_message_background" > + android:background="@drawable/zen_introduction_message_background" + android:theme="@*android:style/ThemeOverlay.DeviceDefault.Accent.Light"> #FFFFFFFF #FFFFFFFF #FF404040 - #ff263238 + + #ff37474F - #ff80CBC4 + #fff4511e #FFFFFFFF #29ffffff @@ -41,7 +42,6 @@ #FFB0BEC5 #B3FFFFFF #66FFFFFF - #99009688 #99FFFFFF #33FFFFFF #FFFFFFFF @@ -99,15 +99,11 @@ #30ffffff - - @color/system_accent_color - #ff757575 #eeeeee - @*android:color/material_deep_teal_500 @*android:color/material_grey_300 #858383 #8a000000 @@ -126,8 +122,6 @@ #03000000 - #4080cbc4 - #ff009688 #80000000 #14FFFFFF @@ -142,14 +136,10 @@ #4dffffff #ffffff - #ff009688 #ffffffff #7fffffff #FFB0BEC5 - #1fffffff - #ff009688 - #ff000000 #ffffff #59000000 @@ -167,10 +157,8 @@ #ffffffff #ff37474f - #ff7fcac3 - @color/material_deep_teal_500 #fff44336 #d9000000 @color/material_grey_600 diff --git a/packages/SystemUI/res/values/styles.xml b/packages/SystemUI/res/values/styles.xml index aeb484f8ffc42..caada1baacd77 100644 --- a/packages/SystemUI/res/values/styles.xml +++ b/packages/SystemUI/res/values/styles.xml @@ -132,7 +132,7 @@ - + - + - - @@ -341,16 +335,16 @@ - -