From a2056ac7d60194c725f14a38a988f93316167138 Mon Sep 17 00:00:00 2001 From: Caitlin Cassidy Date: Tue, 14 Sep 2021 15:11:34 +0000 Subject: [PATCH] [Status Bar Refactor] Remove thisFrac from PanelBar#panelExpansionChanged. `thisFrac` and `frac` always had the same values when logged in different scenarios, which makes sense: PanelViewController sets its fraction internally, then calls #panelExpansionChanged with that value. `thisFrac` is unnecessary, so this CL removes it. Test: atest+manual Bug: 200063118 Change-Id: I48d8dc273815f9d5907ee78be0a801b4dc9234b1 --- .../src/com/android/systemui/statusbar/phone/PanelBar.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelBar.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelBar.java index eca91a3f6fb72..e775e96de749e 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelBar.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelBar.java @@ -182,8 +182,7 @@ public abstract class PanelBar extends FrameLayout { } boolean fullyClosed = true; boolean fullyOpened = false; - if (SPEW) LOG("panelExpansionChanged: start state=%d", mState); - PanelViewController pv = mPanel; + if (SPEW) LOG("panelExpansionChanged: start state=%d, f=%.1f", mState, frac); mExpanded = expanded; mPanelFraction = frac; updateVisibility(); @@ -194,9 +193,7 @@ public abstract class PanelBar extends FrameLayout { onPanelPeeked(); } fullyClosed = false; - final float thisFrac = pv.getExpandedFraction(); - if (SPEW) LOG("panelExpansionChanged: -> %s: f=%.1f", pv.getName(), thisFrac); - fullyOpened = thisFrac >= 1f; + fullyOpened = frac >= 1f; } if (fullyOpened && !mTracking) { go(STATE_OPEN);