From f3e46cf35046694d01e497074300c9f76f70594f Mon Sep 17 00:00:00 2001 From: Beverly Date: Tue, 8 Jun 2021 11:52:21 -0400 Subject: [PATCH] Remove owner and logout views from KeyguardStatusView information is moved to the keyguard indication area Test: manual Fixes: 183708476 Change-Id: I95b229c71006c43aabf5147d1cc6f6c838b8cc85 --- .../layout/keyguard_status_view.xml | 32 ---- .../android/keyguard/KeyguardStatusView.java | 157 ------------------ .../KeyguardStatusViewController.java | 44 ----- .../NotificationPanelViewController.java | 3 +- 4 files changed, 1 insertion(+), 235 deletions(-) diff --git a/packages/SystemUI/res-keyguard/layout/keyguard_status_view.xml b/packages/SystemUI/res-keyguard/layout/keyguard_status_view.xml index 7f645ba816647..31d848d3e4d56 100644 --- a/packages/SystemUI/res-keyguard/layout/keyguard_status_view.xml +++ b/packages/SystemUI/res-keyguard/layout/keyguard_status_view.xml @@ -35,43 +35,11 @@ android:clipChildren="false" android:clipToPadding="false" android:orientation="vertical"> - - - - { - setEnableMarqueeImpl(true); - mPendingMarqueeStart = null; - }; - mHandler.postDelayed(mPendingMarqueeStart, MARQUEE_DELAY_MS); - } - } else { - if (mPendingMarqueeStart != null) { - mHandler.removeCallbacks(mPendingMarqueeStart); - mPendingMarqueeStart = null; - } - setEnableMarqueeImpl(false); - } - } - - private void setEnableMarqueeImpl(boolean enabled) { - if (DEBUG) Log.v(TAG, (enabled ? "Enable" : "Disable") + " transport text marquee"); - if (mOwnerInfo != null) mOwnerInfo.setSelected(enabled); - } - - void setCanShowOwnerInfo(boolean canShowOwnerInfo) { - mCanShowOwnerInfo = canShowOwnerInfo; - mOwnerInfo = findViewById(R.id.owner_info); - if (mOwnerInfo != null) { - if (mCanShowOwnerInfo) { - mOwnerInfo.setVisibility(VISIBLE); - updateOwnerInfo(); - } else { - mOwnerInfo.setVisibility(GONE); - mOwnerInfo = null; - } - } } @Override protected void onFinishInflate() { super.onFinishInflate(); mStatusViewContainer = findViewById(R.id.status_view_container); - mLogoutView = findViewById(R.id.logout); - if (mLogoutView != null) { - mLogoutView.setOnClickListener(this::onLogoutClicked); - } mClockView = findViewById(R.id.keyguard_clock_container); if (KeyguardClockAccessibilityDelegate.isNeeded(mContext)) { mClockView.setAccessibilityDelegate(new KeyguardClockAccessibilityDelegate(mContext)); } - if (mCanShowOwnerInfo) { - mOwnerInfo = findViewById(R.id.owner_info); - } mKeyguardSlice = findViewById(R.id.keyguard_status_area); mTextColor = mClockView.getCurrentTextColor(); @@ -158,7 +96,6 @@ public class KeyguardStatusView extends GridLayout { mMediaHostContainer = findViewById(R.id.status_view_media_container); - updateOwnerInfo(); updateDark(); } @@ -173,60 +110,6 @@ public class KeyguardStatusView extends GridLayout { mShowingHeader = hasHeader; } - @Override - protected void onLayout(boolean changed, int left, int top, int right, int bottom) { - super.onLayout(changed, left, top, right, bottom); - layoutOwnerInfo(); - } - - int getLogoutButtonHeight() { - if (mLogoutView == null) { - return 0; - } - return mLogoutView.getVisibility() == VISIBLE ? mLogoutView.getHeight() : 0; - } - - int getOwnerInfoHeight() { - if (mOwnerInfo == null) { - return 0; - } - return mOwnerInfo.getVisibility() == VISIBLE ? mOwnerInfo.getHeight() : 0; - } - - void updateLogoutView(boolean shouldShowLogout) { - if (mLogoutView == null) { - return; - } - mLogoutView.setVisibility(shouldShowLogout ? VISIBLE : GONE); - // Logout button will stay in language of user 0 if we don't set that manually. - mLogoutView.setText(mContext.getResources().getString( - com.android.internal.R.string.global_action_logout)); - } - - void onDensityOrFontScaleChanged() { - if (mOwnerInfo != null) { - mOwnerInfo.setTextSize(TypedValue.COMPLEX_UNIT_PX, - getResources().getDimensionPixelSize( - com.android.systemui.R.dimen.widget_label_font_size)); - loadBottomMargin(); - } - } - - void updateOwnerInfo() { - if (mOwnerInfo == null) return; - String info = mLockPatternUtils.getDeviceOwnerInfo(); - if (info == null) { - // Use the current user owner information if enabled. - final boolean ownerInfoEnabled = mLockPatternUtils.isOwnerInfoEnabled( - KeyguardUpdateMonitor.getCurrentUser()); - if (ownerInfoEnabled) { - info = mLockPatternUtils.getOwnerInfo(KeyguardUpdateMonitor.getCurrentUser()); - } - } - mOwnerInfo.setText(info); - updateDark(); - } - void setDarkAmount(float darkAmount) { if (mDarkAmount == darkAmount) { return; @@ -238,17 +121,6 @@ public class KeyguardStatusView extends GridLayout { } void updateDark() { - boolean dark = mDarkAmount == 1; - if (mLogoutView != null) { - mLogoutView.setAlpha(dark ? 0 : 1); - } - - if (mOwnerInfo != null) { - boolean hasText = !TextUtils.isEmpty(mOwnerInfo.getText()); - mOwnerInfo.setVisibility(hasText ? VISIBLE : GONE); - layoutOwnerInfo(); - } - final int blendedTextColor = ColorUtils.blendARGB(mTextColor, Color.WHITE, mDarkAmount); mKeyguardSlice.setDarkAmount(mDarkAmount); mClockView.setTextColor(blendedTextColor); @@ -277,13 +149,8 @@ public class KeyguardStatusView extends GridLayout { public void dump(FileDescriptor fd, PrintWriter pw, String[] args) { pw.println("KeyguardStatusView:"); - pw.println(" mOwnerInfo: " + (mOwnerInfo == null - ? "null" : mOwnerInfo.getVisibility() == VISIBLE)); pw.println(" mDarkAmount: " + mDarkAmount); pw.println(" mTextColor: " + Integer.toHexString(mTextColor)); - if (mLogoutView != null) { - pw.println(" logout visible: " + (mLogoutView.getVisibility() == VISIBLE)); - } if (mClockView != null) { mClockView.dump(fd, pw, args); } @@ -297,28 +164,4 @@ public class KeyguardStatusView extends GridLayout { mIconTopMarginWithHeader = getResources().getDimensionPixelSize( R.dimen.widget_vertical_padding_with_header); } - - private void layoutOwnerInfo() { - if (mOwnerInfo != null && mOwnerInfo.getVisibility() != GONE) { - // Animate owner info during wake-up transition - mOwnerInfo.setAlpha(1f - mDarkAmount); - - float ratio = mDarkAmount; - // Calculate how much of it we should crop in order to have a smooth transition - int collapsed = mOwnerInfo.getTop() - mOwnerInfo.getPaddingTop(); - int expanded = mOwnerInfo.getBottom() + mOwnerInfo.getPaddingBottom(); - int toRemove = (int) ((expanded - collapsed) * ratio); - setBottom(getMeasuredHeight() - toRemove); - } - } - - private void onLogoutClicked(View view) { - int currentUserId = KeyguardUpdateMonitor.getCurrentUser(); - try { - mIActivityManager.switchUser(UserHandle.USER_SYSTEM); - mIActivityManager.stopUser(currentUserId, true /*force*/, null); - } catch (RemoteException re) { - Log.e(TAG, "Failed to logout user", re); - } - } } diff --git a/packages/SystemUI/src/com/android/keyguard/KeyguardStatusViewController.java b/packages/SystemUI/src/com/android/keyguard/KeyguardStatusViewController.java index e4cabcb94ebef..32935c293715e 100644 --- a/packages/SystemUI/src/com/android/keyguard/KeyguardStatusViewController.java +++ b/packages/SystemUI/src/com/android/keyguard/KeyguardStatusViewController.java @@ -17,7 +17,6 @@ package com.android.keyguard; import android.graphics.Rect; -import android.os.UserHandle; import android.util.Slog; import com.android.systemui.keyguard.KeyguardUnlockAnimationController; @@ -97,8 +96,6 @@ public class KeyguardStatusViewController extends ViewController