Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't return hidden subscription in getActiveSubscriptionInfoList.

Browse Source 
Bug: 121396526
Test: manual
Change-Id: I3a9f3a9a2628a8e2ad1c401f6fe5e4c5866a0047
This commit is contained in:
Malcolm Chen
2019-02-12 17:29:59 -08:00
parent b6f498a2c9
commit 5b16f8d92b
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
telephony/java/android/telephony/SubscriptionManager.java
View File

@@ -1233,7 +1233,7 @@ public class SubscriptionManager {
@SuppressAutoDoc // Blocked by b/72967236 - no support for carrier privileges @SuppressAutoDoc // Blocked by b/72967236 - no support for carrier privileges
@RequiresPermission(android.Manifest.permission.READ_PHONE_STATE) @RequiresPermission(android.Manifest.permission.READ_PHONE_STATE)
public List<SubscriptionInfo> getActiveSubscriptionInfoList() { public List<SubscriptionInfo> getActiveSubscriptionInfoList() {
return getActiveSubscriptionInfoList(false); return getActiveSubscriptionInfoList(/* userVisibleonly */true);
} }
/** /**
@@ -2855,15 +2855,24 @@ public class SubscriptionManager {
/** /**
* Whether system UI should hide a subscription. If it's a bundled opportunistic * Whether system UI should hide a subscription. If it's a bundled opportunistic
* subscription, it shouldn't show up in anywhere in Settings app, dialer app, * subscription, it shouldn't show up in anywhere in Settings app, dialer app,
* or status bar. * or status bar. Exception is if caller is carrier app, in which case they will
* want to see their own hidden subscriptions.
* *
* @param info the subscriptionInfo to check against. * @param info the subscriptionInfo to check against.
* @return true if this subscription should be hidden. * @return true if this subscription should be hidden.
* *
* @hide * @hide
*/ */
public static boolean shouldHideSubscription(SubscriptionInfo info) { private boolean shouldHideSubscription(SubscriptionInfo info) {
return (info != null && !TextUtils.isEmpty(info.getGroupUuid()) && info.isOpportunistic()); if (info == null) return false;
// If hasCarrierPrivileges or canManageSubscription returns true, it means caller
// has carrier privilege.
boolean hasCarrierPrivilegePermission = (info.isEmbedded() && canManageSubscription(info))
|| TelephonyManager.from(mContext).hasCarrierPrivileges(info.getSubscriptionId());
return (!TextUtils.isEmpty(info.getGroupUuid()) && info.isOpportunistic()
&& !hasCarrierPrivilegePermission);
} }
/** /**