From d5875d98f06817f78bd974842a8a9c2d41802d20 Mon Sep 17 00:00:00 2001 From: Jeff Brown Date: Sun, 9 Oct 2011 14:59:37 -0700 Subject: [PATCH] Always log StrictMode violations on ENG builds. The drop-box is too quiet and it masking real problems from developers. On ENG builds, use both logging and the drop-box to ensure that problems are noticed promptly. Change-Id: Id8fb8d392a7e01b532b73cb1a026b0d1f17af742 --- core/java/android/os/StrictMode.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/core/java/android/os/StrictMode.java b/core/java/android/os/StrictMode.java index 68385b4b4b713..4d7a9bbf89386 100644 --- a/core/java/android/os/StrictMode.java +++ b/core/java/android/os/StrictMode.java @@ -908,6 +908,9 @@ public final class StrictMode { if (!IS_USER_BUILD) { threadPolicyMask |= StrictMode.PENALTY_DROPBOX; + if (IS_ENG_BUILD) { + threadPolicyMask |= StrictMode.PENALTY_LOG; + } } if (doFlashes) { threadPolicyMask |= StrictMode.PENALTY_FLASH; @@ -918,7 +921,11 @@ public final class StrictMode { if (IS_USER_BUILD) { setCloseGuardEnabled(false); } else { - setVmPolicy(new VmPolicy.Builder().detectAll().penaltyDropBox().build()); + VmPolicy.Builder policyBuilder = new VmPolicy.Builder().detectAll().penaltyDropBox(); + if (IS_ENG_BUILD) { + policyBuilder.penaltyLog(); + } + setVmPolicy(policyBuilder.build()); setCloseGuardEnabled(vmClosableObjectLeaksEnabled()); } return true;