From 5ade32bdf61b3453d3710f6f81c29a694219c342 Mon Sep 17 00:00:00 2001 From: jasonwshsu Date: Thu, 22 Apr 2021 15:41:20 +0800 Subject: [PATCH] Add accessibility shortcut icon into adaptive icon * add/modify icons list: color correction, color inversion, magnification, extra dim Fix: 184081577 Test: manual test Change-Id: I5ceee75f0263072805af23a7bbdfc68d7008db6e --- .../dialog/AccessibilityTargetHelper.java | 43 ++++--- .../ic_accessibility_color_correction.xml | 48 ++------ ...essibility_color_correction_foreground.xml | 26 ++++ .../ic_accessibility_color_inversion.xml | 58 ++------- ...cessibility_color_inversion_foreground.xml | 54 +++++++++ .../ic_accessibility_magnification.xml | 111 ++---------------- ...accessibility_magnification_foreground.xml | 26 ++++ .../ic_accessibility_reduce_bright_colors.xml | 24 ++++ ...bility_reduce_bright_colors_foreground.xml | 54 +++++++++ core/res/res/values/colors.xml | 6 + core/res/res/values/dimens.xml | 3 + core/res/res/values/symbols.xml | 1 + 12 files changed, 246 insertions(+), 208 deletions(-) create mode 100644 core/res/res/drawable/ic_accessibility_color_correction_foreground.xml create mode 100644 core/res/res/drawable/ic_accessibility_color_inversion_foreground.xml create mode 100644 core/res/res/drawable/ic_accessibility_magnification_foreground.xml create mode 100644 core/res/res/drawable/ic_accessibility_reduce_bright_colors.xml create mode 100644 core/res/res/drawable/ic_accessibility_reduce_bright_colors_foreground.xml diff --git a/core/java/com/android/internal/accessibility/dialog/AccessibilityTargetHelper.java b/core/java/com/android/internal/accessibility/dialog/AccessibilityTargetHelper.java index 9d06bb92b2056..f2d91ba308426 100644 --- a/core/java/com/android/internal/accessibility/dialog/AccessibilityTargetHelper.java +++ b/core/java/com/android/internal/accessibility/dialog/AccessibilityTargetHelper.java @@ -203,34 +203,33 @@ public final class AccessibilityTargetHelper { final InvisibleToggleAllowListingFeatureTarget magnification = new InvisibleToggleAllowListingFeatureTarget(context, - shortcutType, - isShortcutContained(context, shortcutType, MAGNIFICATION_CONTROLLER_NAME), - MAGNIFICATION_CONTROLLER_NAME, - context.getString(R.string.accessibility_magnification_chooser_text), - context.getDrawable(R.drawable.ic_accessibility_magnification), - Settings.Secure.ACCESSIBILITY_DISPLAY_MAGNIFICATION_NAVBAR_ENABLED); + shortcutType, + isShortcutContained(context, shortcutType, MAGNIFICATION_CONTROLLER_NAME), + MAGNIFICATION_CONTROLLER_NAME, + context.getString(R.string.accessibility_magnification_chooser_text), + context.getDrawable(R.drawable.ic_accessibility_magnification), + Settings.Secure.ACCESSIBILITY_DISPLAY_MAGNIFICATION_NAVBAR_ENABLED); final ToggleAllowListingFeatureTarget daltonizer = new ToggleAllowListingFeatureTarget(context, - shortcutType, - isShortcutContained(context, shortcutType, - DALTONIZER_COMPONENT_NAME.flattenToString()), - DALTONIZER_COMPONENT_NAME.flattenToString(), - context.getString(R.string.color_correction_feature_name), - context.getDrawable(R.drawable.ic_accessibility_color_correction), - Settings.Secure.ACCESSIBILITY_DISPLAY_DALTONIZER_ENABLED); + shortcutType, + isShortcutContained(context, shortcutType, + DALTONIZER_COMPONENT_NAME.flattenToString()), + DALTONIZER_COMPONENT_NAME.flattenToString(), + context.getString(R.string.color_correction_feature_name), + context.getDrawable(R.drawable.ic_accessibility_color_correction), + Settings.Secure.ACCESSIBILITY_DISPLAY_DALTONIZER_ENABLED); final ToggleAllowListingFeatureTarget colorInversion = new ToggleAllowListingFeatureTarget(context, - shortcutType, - isShortcutContained(context, shortcutType, - COLOR_INVERSION_COMPONENT_NAME.flattenToString()), - COLOR_INVERSION_COMPONENT_NAME.flattenToString(), - context.getString(R.string.color_inversion_feature_name), - context.getDrawable(R.drawable.ic_accessibility_color_inversion), - Settings.Secure.ACCESSIBILITY_DISPLAY_INVERSION_ENABLED); + shortcutType, + isShortcutContained(context, shortcutType, + COLOR_INVERSION_COMPONENT_NAME.flattenToString()), + COLOR_INVERSION_COMPONENT_NAME.flattenToString(), + context.getString(R.string.color_inversion_feature_name), + context.getDrawable(R.drawable.ic_accessibility_color_inversion), + Settings.Secure.ACCESSIBILITY_DISPLAY_INVERSION_ENABLED); - // TODO: Update with shortcut icon final ToggleAllowListingFeatureTarget reduceBrightColors = new ToggleAllowListingFeatureTarget(context, shortcutType, @@ -238,7 +237,7 @@ public final class AccessibilityTargetHelper { REDUCE_BRIGHT_COLORS_COMPONENT_NAME.flattenToString()), REDUCE_BRIGHT_COLORS_COMPONENT_NAME.flattenToString(), context.getString(R.string.reduce_bright_colors_feature_name), - null, + context.getDrawable(R.drawable.ic_accessibility_reduce_bright_colors), Settings.Secure.REDUCE_BRIGHT_COLORS_ACTIVATED); targets.add(magnification); diff --git a/core/res/res/drawable/ic_accessibility_color_correction.xml b/core/res/res/drawable/ic_accessibility_color_correction.xml index ed09d5704ad2b..f1dbfb22af53d 100644 --- a/core/res/res/drawable/ic_accessibility_color_correction.xml +++ b/core/res/res/drawable/ic_accessibility_color_correction.xml @@ -1,5 +1,5 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + diff --git a/core/res/res/drawable/ic_accessibility_color_correction_foreground.xml b/core/res/res/drawable/ic_accessibility_color_correction_foreground.xml new file mode 100644 index 0000000000000..ecb5065163d1e --- /dev/null +++ b/core/res/res/drawable/ic_accessibility_color_correction_foreground.xml @@ -0,0 +1,26 @@ + + + + + \ No newline at end of file diff --git a/core/res/res/drawable/ic_accessibility_color_inversion.xml b/core/res/res/drawable/ic_accessibility_color_inversion.xml index d69a169d0fb38..f8558807454ae 100644 --- a/core/res/res/drawable/ic_accessibility_color_inversion.xml +++ b/core/res/res/drawable/ic_accessibility_color_inversion.xml @@ -1,5 +1,5 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + diff --git a/core/res/res/drawable/ic_accessibility_color_inversion_foreground.xml b/core/res/res/drawable/ic_accessibility_color_inversion_foreground.xml new file mode 100644 index 0000000000000..7fc3aa686f5ac --- /dev/null +++ b/core/res/res/drawable/ic_accessibility_color_inversion_foreground.xml @@ -0,0 +1,54 @@ + + + + + + + + + + + \ No newline at end of file diff --git a/core/res/res/drawable/ic_accessibility_magnification.xml b/core/res/res/drawable/ic_accessibility_magnification.xml index 5dab47951cda3..f3b28877ac0fb 100644 --- a/core/res/res/drawable/ic_accessibility_magnification.xml +++ b/core/res/res/drawable/ic_accessibility_magnification.xml @@ -1,5 +1,5 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + diff --git a/core/res/res/drawable/ic_accessibility_magnification_foreground.xml b/core/res/res/drawable/ic_accessibility_magnification_foreground.xml new file mode 100644 index 0000000000000..7ce18808fcf2e --- /dev/null +++ b/core/res/res/drawable/ic_accessibility_magnification_foreground.xml @@ -0,0 +1,26 @@ + + + + + diff --git a/core/res/res/drawable/ic_accessibility_reduce_bright_colors.xml b/core/res/res/drawable/ic_accessibility_reduce_bright_colors.xml new file mode 100644 index 0000000000000..4eab97ba5c1ad --- /dev/null +++ b/core/res/res/drawable/ic_accessibility_reduce_bright_colors.xml @@ -0,0 +1,24 @@ + + + + + + + + diff --git a/core/res/res/drawable/ic_accessibility_reduce_bright_colors_foreground.xml b/core/res/res/drawable/ic_accessibility_reduce_bright_colors_foreground.xml new file mode 100644 index 0000000000000..58609dacd9b12 --- /dev/null +++ b/core/res/res/drawable/ic_accessibility_reduce_bright_colors_foreground.xml @@ -0,0 +1,54 @@ + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/core/res/res/values/colors.xml b/core/res/res/values/colors.xml index 0213c60e9f60c..36168e7bd937c 100644 --- a/core/res/res/values/colors.xml +++ b/core/res/res/values/colors.xml @@ -427,4 +427,10 @@ #000000 + + + #5F6368 + #F50D60 + #00BCD4 + #546E7A diff --git a/core/res/res/values/dimens.xml b/core/res/res/values/dimens.xml index 43c0ec979281b..123ce58364dbc 100644 --- a/core/res/res/values/dimens.xml +++ b/core/res/res/values/dimens.xml @@ -573,6 +573,9 @@ 4dp + + 21.88% + 8dp diff --git a/core/res/res/values/symbols.xml b/core/res/res/values/symbols.xml index 78a794a35bba7..adb966ce4ef4b 100644 --- a/core/res/res/values/symbols.xml +++ b/core/res/res/values/symbols.xml @@ -3403,6 +3403,7 @@ +