Merge "Prevent draw passes when nothing actually changes" into mnc-dev

This commit is contained in:
Jorim Jaggi
2015-05-26 21:17:54 +00:00
committed by Android (Google) Code Review

View File

@@ -56,10 +56,13 @@ public class SignalClusterView
private boolean mVpnVisible = false; private boolean mVpnVisible = false;
private boolean mEthernetVisible = false; private boolean mEthernetVisible = false;
private int mEthernetIconId = 0; private int mEthernetIconId = 0;
private int mLastEthernetIconId = -1;
private boolean mWifiVisible = false; private boolean mWifiVisible = false;
private int mWifiStrengthId = 0; private int mWifiStrengthId = 0;
private int mLastWifiStrengthId = -1;
private boolean mIsAirplaneMode = false; private boolean mIsAirplaneMode = false;
private int mAirplaneIconId = 0; private int mAirplaneIconId = 0;
private int mLastAirplaneIconId = -1;
private String mAirplaneContentDescription; private String mAirplaneContentDescription;
private String mWifiDescription; private String mWifiDescription;
private String mEthernetDescription; private String mEthernetDescription;
@@ -275,10 +278,14 @@ public class SignalClusterView
if (mEthernet != null) { if (mEthernet != null) {
mEthernet.setImageDrawable(null); mEthernet.setImageDrawable(null);
mEthernetDark.setImageDrawable(null);
mLastEthernetIconId = -1;
} }
if (mWifi != null) { if (mWifi != null) {
mWifi.setImageDrawable(null); mWifi.setImageDrawable(null);
mWifiDark.setImageDrawable(null);
mLastWifiStrengthId = -1;
} }
for (PhoneState state : mPhoneStates) { for (PhoneState state : mPhoneStates) {
@@ -290,8 +297,9 @@ public class SignalClusterView
} }
} }
if(mAirplane != null) { if (mAirplane != null) {
mAirplane.setImageDrawable(null); mAirplane.setImageDrawable(null);
mLastAirplaneIconId = -1;
} }
apply(); apply();
@@ -310,8 +318,11 @@ public class SignalClusterView
if (DEBUG) Log.d(TAG, String.format("vpn: %s", mVpnVisible ? "VISIBLE" : "GONE")); if (DEBUG) Log.d(TAG, String.format("vpn: %s", mVpnVisible ? "VISIBLE" : "GONE"));
if (mEthernetVisible) { if (mEthernetVisible) {
mEthernet.setImageResource(mEthernetIconId); if (mLastEthernetIconId != mEthernetIconId) {
mEthernetDark.setImageResource(mEthernetIconId); mEthernet.setImageResource(mEthernetIconId);
mEthernetDark.setImageResource(mEthernetIconId);
mLastEthernetIconId = mEthernetIconId;
}
mEthernetGroup.setContentDescription(mEthernetDescription); mEthernetGroup.setContentDescription(mEthernetDescription);
mEthernetGroup.setVisibility(View.VISIBLE); mEthernetGroup.setVisibility(View.VISIBLE);
} else { } else {
@@ -324,8 +335,11 @@ public class SignalClusterView
if (mWifiVisible) { if (mWifiVisible) {
mWifi.setImageResource(mWifiStrengthId); if (mWifiStrengthId != mLastWifiStrengthId) {
mWifiDark.setImageResource(mWifiStrengthId); mWifi.setImageResource(mWifiStrengthId);
mWifiDark.setImageResource(mWifiStrengthId);
mLastWifiStrengthId = mWifiStrengthId;
}
mWifiGroup.setContentDescription(mWifiDescription); mWifiGroup.setContentDescription(mWifiDescription);
mWifiGroup.setVisibility(View.VISIBLE); mWifiGroup.setVisibility(View.VISIBLE);
} else { } else {
@@ -349,7 +363,10 @@ public class SignalClusterView
} }
if (mIsAirplaneMode) { if (mIsAirplaneMode) {
mAirplane.setImageResource(mAirplaneIconId); if (mLastAirplaneIconId != mAirplaneIconId) {
mAirplane.setImageResource(mAirplaneIconId);
mLastAirplaneIconId = mAirplaneIconId;
}
mAirplane.setContentDescription(mAirplaneContentDescription); mAirplane.setContentDescription(mAirplaneContentDescription);
mAirplane.setVisibility(View.VISIBLE); mAirplane.setVisibility(View.VISIBLE);
} else { } else {