Merge "CEC: Drop TODOs marked as fixed/obsolete" am: 6e7f16ac1e

Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1676434

Change-Id: I09f86f2409cfdd3299fa453b1059fed490d623bd
This commit is contained in:
Treehugger Robot
2021-04-19 10:10:46 +00:00
committed by Automerger Merge Worker
5 changed files with 8 additions and 18 deletions

View File

@@ -63,7 +63,6 @@ public final class HdmiAudioSystemClient extends HdmiClient {
* *
* @hide * @hide
*/ */
// TODO(b/110094868): unhide and add @SystemApi for Q
public interface SetSystemAudioModeCallback { public interface SetSystemAudioModeCallback {
/** /**
* Called when the input was changed. * Called when the input was changed.
@@ -74,7 +73,6 @@ public final class HdmiAudioSystemClient extends HdmiClient {
} }
/** @hide */ /** @hide */
// TODO(b/110094868): unhide and add @SystemApi for Q
@Override @Override
public int getDeviceType() { public int getDeviceType() {
return HdmiDeviceInfo.DEVICE_AUDIO_SYSTEM; return HdmiDeviceInfo.DEVICE_AUDIO_SYSTEM;
@@ -143,7 +141,6 @@ public final class HdmiAudioSystemClient extends HdmiClient {
* *
* @hide * @hide
*/ */
// TODO(b/110094868): unhide and add @SystemApi for Q
public void setSystemAudioMode(boolean state, @NonNull SetSystemAudioModeCallback callback) { public void setSystemAudioMode(boolean state, @NonNull SetSystemAudioModeCallback callback) {
// TODO(amyjojo): implement this when needed. // TODO(amyjojo): implement this when needed.
} }
@@ -156,7 +153,6 @@ public final class HdmiAudioSystemClient extends HdmiClient {
* *
* @hide * @hide
*/ */
// TODO(b/110094868): unhide and add @SystemApi for Q
public void setSystemAudioModeOnForAudioOnlySource() { public void setSystemAudioModeOnForAudioOnlySource() {
try { try {
mService.setSystemAudioModeOnForAudioOnlySource(); mService.setSystemAudioModeOnForAudioOnlySource();

View File

@@ -65,7 +65,6 @@ public abstract class HdmiClient {
* @param isPressed true if this is key press event * @param isPressed true if this is key press event
* *
* @hide * @hide
* TODO(b/110094868): unhide for Q
*/ */
public void sendVolumeKeyEvent(int keyCode, boolean isPressed) { public void sendVolumeKeyEvent(int keyCode, boolean isPressed) {
try { try {

View File

@@ -472,7 +472,6 @@ public final class HdmiControlManager {
* *
* @return {@link HdmiAudioSystemClient} instance. {@code null} on failure. * @return {@link HdmiAudioSystemClient} instance. {@code null} on failure.
* *
* TODO(b/110094868): unhide for Q
* @hide * @hide
*/ */
@Nullable @Nullable

View File

@@ -24,7 +24,6 @@ import java.lang.annotation.RetentionPolicy;
/** /**
* Various utilities related to HDMI CEC. * Various utilities related to HDMI CEC.
* *
* TODO(b/110094868): unhide for Q
* @hide * @hide
*/ */
public final class HdmiUtils { public final class HdmiUtils {
@@ -84,7 +83,6 @@ public final class HdmiUtils {
} }
/** /**
* TODO(b/110094868): unhide for Q
* @hide * @hide
*/ */
@Retention(RetentionPolicy.SOURCE) @Retention(RetentionPolicy.SOURCE)
@@ -95,49 +93,49 @@ public final class HdmiUtils {
public @interface HdmiAddressRelativePosition {} public @interface HdmiAddressRelativePosition {}
/** /**
* HDMI relative position is not determined. * HDMI relative position is not determined.
* TODO(b/110094868): unhide for Q *
* @hide * @hide
*/ */
public static final int HDMI_RELATIVE_POSITION_UNKNOWN = 0; public static final int HDMI_RELATIVE_POSITION_UNKNOWN = 0;
/** /**
* HDMI relative position: directly blow the device. * HDMI relative position: directly blow the device.
* TODO(b/110094868): unhide for Q *
* @hide * @hide
*/ */
public static final int HDMI_RELATIVE_POSITION_DIRECTLY_BELOW = 1; public static final int HDMI_RELATIVE_POSITION_DIRECTLY_BELOW = 1;
/** /**
* HDMI relative position: indirectly below the device. * HDMI relative position: indirectly below the device.
* TODO(b/110094868): unhide for Q *
* @hide * @hide
*/ */
public static final int HDMI_RELATIVE_POSITION_BELOW = 2; public static final int HDMI_RELATIVE_POSITION_BELOW = 2;
/** /**
* HDMI relative position: the same device. * HDMI relative position: the same device.
* TODO(b/110094868): unhide for Q *
* @hide * @hide
*/ */
public static final int HDMI_RELATIVE_POSITION_SAME = 3; public static final int HDMI_RELATIVE_POSITION_SAME = 3;
/** /**
* HDMI relative position: directly above the device. * HDMI relative position: directly above the device.
* TODO(b/110094868): unhide for Q *
* @hide * @hide
*/ */
public static final int HDMI_RELATIVE_POSITION_DIRECTLY_ABOVE = 4; public static final int HDMI_RELATIVE_POSITION_DIRECTLY_ABOVE = 4;
/** /**
* HDMI relative position: indirectly above the device. * HDMI relative position: indirectly above the device.
* TODO(b/110094868): unhide for Q *
* @hide * @hide
*/ */
public static final int HDMI_RELATIVE_POSITION_ABOVE = 5; public static final int HDMI_RELATIVE_POSITION_ABOVE = 5;
/** /**
* HDMI relative position: directly below a same device. * HDMI relative position: directly below a same device.
* TODO(b/110094868): unhide for Q *
* @hide * @hide
*/ */
public static final int HDMI_RELATIVE_POSITION_SIBLING = 6; public static final int HDMI_RELATIVE_POSITION_SIBLING = 6;
/** /**
* HDMI relative position: different branch. * HDMI relative position: different branch.
* TODO(b/110094868): unhide for Q *
* @hide * @hide
*/ */
public static final int HDMI_RELATIVE_POSITION_DIFFERENT_BRANCH = 7; public static final int HDMI_RELATIVE_POSITION_DIFFERENT_BRANCH = 7;

View File

@@ -353,7 +353,6 @@ public class HdmiCecLocalDeviceAudioSystem extends HdmiCecLocalDeviceSource {
super.disableDevice(initiatedByCec, callback); super.disableDevice(initiatedByCec, callback);
assertRunOnServiceThread(); assertRunOnServiceThread();
mService.unregisterTvInputCallback(mTvInputCallback); mService.unregisterTvInputCallback(mTvInputCallback);
// TODO(b/129088603): check disableDevice and onStandby behaviors per spec
} }
@Override @Override
@@ -1046,7 +1045,6 @@ public class HdmiCecLocalDeviceAudioSystem extends HdmiCecLocalDeviceSource {
} }
protected void switchToAudioInput() { protected void switchToAudioInput() {
// TODO(b/111396634): switch input according to PROPERTY_SYSTEM_AUDIO_MODE_AUDIO_PORT
} }
protected boolean isDirectConnectToTv() { protected boolean isDirectConnectToTv() {