From bca81c3b484175e4744f35e2c3d3b8719d34fe8f Mon Sep 17 00:00:00 2001 From: Ilya Matyukhin Date: Tue, 22 Oct 2019 16:17:59 -0700 Subject: [PATCH] Remove no longer needed getErrorString(...) The strings are now obtained by the manager classes, such as FingerprintManager and FaceManager. BiometricService just passes down the error codes. Bug: 141025588 Test: atest BiometricServiceTest Test: the errors are shown correctly in BiometricPromptDemo Change-Id: I19711c81dc86eae5e0c5d12eaea9a2a9a5bd1f2c --- .../android/server/biometrics/BiometricService.java | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/services/core/java/com/android/server/biometrics/BiometricService.java b/services/core/java/com/android/server/biometrics/BiometricService.java index 619c21e7646bc..44c81fc09b2a3 100644 --- a/services/core/java/com/android/server/biometrics/BiometricService.java +++ b/services/core/java/com/android/server/biometrics/BiometricService.java @@ -988,18 +988,6 @@ public class BiometricService extends SystemService { } } - private String getErrorString(int modality, int error, int vendorCode) { - for (AuthenticatorWrapper authenticator : mAuthenticators) { - if (authenticator.modality == modality) { - // TODO(b/141025588): Refactor IBiometricServiceReceiver.aidl#onError(...) to not - // ask for a String error message, but derive it from the error code instead. - return ""; - } - } - Slog.w(TAG, "Unable to get error string for modality: " + modality); - return null; - } - private void logDialogDismissed(int reason) { if (reason == BiometricPrompt.DISMISSED_REASON_BIOMETRIC_CONFIRMED) { // Explicit auth, authentication confirmed.