From 57f6dbc578d4c0d722b51a2716a1cc1d32237449 Mon Sep 17 00:00:00 2001 From: Jeff Sharkey Date: Fri, 29 Mar 2019 13:57:31 -0600 Subject: [PATCH] Remove support for file:// items. We've messaged since the N release that file:// Uris are going away, and we've been crashing those apps via StrictMode for many years. The broader storage changes in Q mean it's finally a good time to say we only handle content:// items. Bug: 123212933 Test: none Change-Id: I69a791468c4bcf45b0022cf52264e78f94bfdeae --- packages/PackageInstaller/AndroidManifest.xml | 2 -- .../core/java/com/android/server/pm/PackageManagerService.java | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/PackageInstaller/AndroidManifest.xml b/packages/PackageInstaller/AndroidManifest.xml index 62535b635e440..b0e2700a1f309 100644 --- a/packages/PackageInstaller/AndroidManifest.xml +++ b/packages/PackageInstaller/AndroidManifest.xml @@ -43,14 +43,12 @@ - - diff --git a/services/core/java/com/android/server/pm/PackageManagerService.java b/services/core/java/com/android/server/pm/PackageManagerService.java index 3833afc6c63b8..1a17328d8c32e 100644 --- a/services/core/java/com/android/server/pm/PackageManagerService.java +++ b/services/core/java/com/android/server/pm/PackageManagerService.java @@ -3502,7 +3502,7 @@ public class PackageManagerService extends IPackageManager.Stub private @NonNull String getRequiredInstallerLPr() { final Intent intent = new Intent(Intent.ACTION_INSTALL_PACKAGE); intent.addCategory(Intent.CATEGORY_DEFAULT); - intent.setDataAndType(Uri.fromFile(new File("foo.apk")), PACKAGE_MIME_TYPE); + intent.setDataAndType(Uri.parse("content://com.example/foo.apk"), PACKAGE_MIME_TYPE); final List matches = queryIntentActivitiesInternal(intent, PACKAGE_MIME_TYPE, MATCH_SYSTEM_ONLY | MATCH_DIRECT_BOOT_AWARE | MATCH_DIRECT_BOOT_UNAWARE,