From 57f026191ef61470eb433b52994b20c4efea8db4 Mon Sep 17 00:00:00 2001 From: Robert Carr Date: Mon, 1 Apr 2019 15:27:26 -0700 Subject: [PATCH] SurfaceView: Correct comparison operator. We show the background when the Surface view is BEHIND not when it is in front. Bug: 129359905 Test: SurfaceViewSurfaceValidatorTest#testOnTopHasNoBackground Change-Id: I3f3139d50972626e4c70139f1008d70d2935cd0b --- core/java/android/view/SurfaceView.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/android/view/SurfaceView.java b/core/java/android/view/SurfaceView.java index e931448652c0e..8070e76d1b407 100644 --- a/core/java/android/view/SurfaceView.java +++ b/core/java/android/view/SurfaceView.java @@ -491,7 +491,7 @@ public class SurfaceView extends View implements ViewRootImpl.WindowStoppedCallb if (mBackgroundControl == null) { return; } - if ((mSubLayer > 0) && ((mSurfaceFlags & SurfaceControl.OPAQUE) != 0)) { + if ((mSubLayer < 0) && ((mSurfaceFlags & SurfaceControl.OPAQUE) != 0)) { mBackgroundControl.show(); mBackgroundControl.setLayer(Integer.MIN_VALUE); } else {